-
Notifications
You must be signed in to change notification settings - Fork 5k
DO NOT MERGE beta6 changes #49402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DO NOT MERGE beta6 changes #49402
Conversation
* Added start recording failed event. * Export latest api changes. * Build issue resolved in Teams Extension User Identifier Model. * Made changes in TranscriptionData for StreamingData Parse and added test scenario. * Added api version. * Updating new common library for the teamsextension users * latest api run --------- Co-authored-by: Vinothini Dharmaraj <[email protected]>
API change check APIView has identified API level changes in this PR and created following API reviews. |
@@ -223,14 +209,9 @@ public static partial class CallAutomationModelFactory | |||
public static Azure.Communication.CallAutomation.CreateCallFailed CreateCallFailed(string callConnectionId = null, string serverCallId = null, string correlationId = null, Azure.Communication.CallAutomation.ResultInformation resultInformation = null, string operationContext = null) { throw null; } | |||
public static Azure.Communication.CallAutomation.CreateCallResult CreateCallResult(Azure.Communication.CallAutomation.CallConnection callConnection = null, Azure.Communication.CallAutomation.CallConnectionProperties callConnectionProperties = null) { throw null; } | |||
public static Azure.Communication.CallAutomation.DtmfResult DtmfResult(System.Collections.Generic.IEnumerable<Azure.Communication.CallAutomation.DtmfTone> tones = null) { throw null; } | |||
public static Azure.Communication.CallAutomation.ErrorDetails ErrorDetails(string code = null, string message = null, Azure.Communication.CallAutomation.ErrorDetails innerError = null) { throw null; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file across all API versions, including alphas, betas, and GAs?
@@ -7,7 +7,7 @@ | |||
|
|||
namespace Azure.Communication.CallAutomation | |||
{ | |||
/// <summary> Hold Failed event. </summary> | |||
/// <summary> The HoldFailed. </summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is generated but the old summary text was better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be updated through the api spec
…ingCall event (#49856) * Ran live tests and recorded. All pass successfully. * Added null check to CustomCallingContext. * Added unit tests for IncomingCall event. Handling both non-null and null CustomContext.
* updating the changelog and version changes for the Beta6 release * removing the pmaendpoint * updating the changelog for the incomingcall event * removing feature that is not supported * updating the changelog release date * updating space * export api * adding startrecording failed event
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.