Make it clearer where GetForegroundWindow method comes from
#49414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sample makes use of `GetForegroundWindow()`, but doesn't show where the method comes from. Added the DllImport for that method to show where the windows handle comes from.
afscrome
requested review from
maorleger,
billwert,
mpodwysocki,
xiangyan99 and
minhanh-phan
github-actions
bot
added
Azure.Identity
Community Contribution
|
Thank you for your contribution @afscrome! We will review the pull request and get back to you soon. |
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
|
API change check API changes are not detected in this pull request. |
christothes
reviewed
Apr 15, 2025
Comment on lines
+59
to
+60
| [DllImport("user32.dll")] | ||
| static extern IntPtr GetForegroundWindow(); |
There was a problem hiding this comment.
Thanks for the contribution!
This is failing the build because the exact same code needs to be placed in this file in the same location. However, the file in question already contains this code, just outside the snippet, so for this to build, you'll need to add it to the .cs file as so:
#if SNIPPET
[DllImport("user32.dll")]
static extern IntPtr GetForegroundWindow();
#endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
The sample makes use of
GetForegroundWindow(), but doesn't show where the method comes from.Added the DllImport for that method to show where the windows handle comes from.