Add non aot compatible support for collection reading and writing #49755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Pull Request Overview
This PR adds non-AOT compatible support for collection reading and writing while updating testing and reflection-based builder components.
- Updated test classes to indicate that reflection builder support is disabled.
- Removed obsolete tests and replaced/refactored the ReflectionContext with a new ModelReaderWriterReflectionContext and additional reflection builder implementations.
- Updated ModelReaderWriter methods and related API definitions with dynamic reflection attributes to support non-AOT scenarios.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/System.ClientModel/tests/ModelReaderWriterTests/Models/AvailabilitySetDatas/ImmutableDictionaryTests.cs | Added override for HasReflectionBuilderSupport set to false. |
| sdk/core/System.ClientModel/tests/ModelReaderWriterTests/Models/AvailabilitySetDatas/ImmutableArrayTests.cs | Added override for HasReflectionBuilderSupport set to false. |
| sdk/core/System.ClientModel/tests/ModelReaderWriterTests/Models/AvailabilitySetDatas/DictionaryIntKeyTests.cs | Added override for HasReflectionBuilderSupport set to false. |
| sdk/core/System.ClientModel/tests/ModelReaderWriterTests/Models/AvailabilitySetDatas/CustomCollectionTests.cs | Added override for HasReflectionBuilderSupport set to false. |
| sdk/core/System.ClientModel/tests/ModelReaderWriterTests/ModelReaderWriterGeneralTests.cs | Removed tests for non-generic list reading which are now unsupported. |
| sdk/core/System.ClientModel/src/ModelReaderWriter/ReflectionModelBuilder.cs, Reflection* files | Introduced several new reflection builder classes to support non-AOT usage and removed the old ReflectionContext. |
| sdk/core/System.ClientModel/src/ModelReaderWriter/ModelReaderWriter.cs | Updated Write and Read methods to use the new ModelReaderWriterReflectionContext and added reflection attributes. |
| sdk/core/System.ClientModel/api/* | Updated API definitions across target frameworks removing constraints and adding dynamic code attributes. |
...re/System.ClientModel/src/ModelReaderWriter/Reflection/ModelReaderWriterReflectionContext.cs
Show resolved
Hide resolved
...re/System.ClientModel/src/ModelReaderWriter/Reflection/ModelReaderWriterReflectionContext.cs
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
JoshLove-msft
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48294
Should not be shipped until we release new version of all sdks which opt into AOT compatibility as mentioned in this tracking issue #48292
Needs to wait for #49945 and SCM 1.4.1 to go live.