dotnet sdk changes for sitemanager #49954
Conversation
bsomeshekar
requested review from
ArcturusZhang,
ArthurMa1978 and
jsquire
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @bsomeshekar! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for managing SiteManager resources in the .NET SDK by introducing new pipeline configurations, API definitions, tests, samples, and documentation updates.
- Added CI pipeline YAML configuration specific to SiteManager.
- Introduced API surface, test helpers, and sample usage for creating, updating, and deleting SiteManager resources.
- Updated solution and project files, along with documentation and changelog entries, to support the new SiteManager service.
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/sitemanager/ci.mgmt.yml | New CI pipeline configuration for SiteManager. |
| sdk/sitemanager/Azure.ResourceManager.SiteManager/tsp-location.yaml | Adds specification location reference for SiteManager. |
| sdk/sitemanager/Azure.ResourceManager.SiteManager/tests/*.cs | New test infrastructure and test cases for CRUD operations. |
| sdk/sitemanager/Azure.ResourceManager.SiteManager/api/*.cs | Generated API definitions for SiteManager. |
| sdk/sitemanager/Azure.ResourceManager.SiteManager/samples/*.cs | Sample code demonstrating usage of SiteManager resource operations. |
| Documentation files (README.md, CHANGELOG.md, etc.) | Updated documentation to reflect the new service. |
| sdk/resourcemanager/ci.mgmt.yml | Updated to include SiteManager in the CI trigger and PR paths. |
Comments suppressed due to low confidence (1)
sdk/sitemanager/Azure.ResourceManager.SiteManager/tests/Scenario/SiteCollectionTests.cs:54
- [nitpick] The variable name 'UpdatedSite' starts with an uppercase letter; consider renaming it to 'updatedSite' for consistency with common local variable naming conventions.
var UpdatedSite = await UpdateSiteAsync(resourceGroup, siteName);
sdk/sitemanager/Azure.ResourceManager.SiteManager/tests/SiteManagerManagementTestBase.cs
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Your account lacks the public GitHub organization memberships and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
I have requested for access, will get back once I got the access. |
got the required permissions and updated code owners file |
.github/CODEOWNERS
Outdated
| # PRLabel: %SiteManager | ||
| /sdk/sitemanager/Azure.ResourceManager.*/ @bsomeshekar @amrawat | ||
|
|
||
| # ServiceLabel: %SiteManager |
There was a problem hiding this comment.
| # ServiceLabel: %SiteManager | |
| # ServiceLabel: %SiteManager %Mgmt |
.github/CODEOWNERS
Outdated
| @@ -1133,6 +1133,12 @@ | |||
| # ServiceLabel: %Weights & Biases %Mgmt | |||
| # ServiceOwners: @aggarwalsw | |||
|
|
|||
| # PRLabel: %SiteManager | |||
There was a problem hiding this comment.
Please move this entry such that alphabetical ordering by label is maintained.
.github/CODEOWNERS
Outdated
| @@ -1133,6 +1133,12 @@ | |||
| # ServiceLabel: %Weights & Biases %Mgmt | |||
| # ServiceOwners: @aggarwalsw | |||
|
|
|||
| # PRLabel: %SiteManager | |||
| /sdk/sitemanager/Azure.ResourceManager.*/ @bsomeshekar @amrawat | |||
There was a problem hiding this comment.
Neither of these are valid CODEOWNERS:
- bsomeshekar does not have a public membership to the Azure GitHub organization.
- amrawat does not have write permissions nor public memberships to Azure and Microsoft.
Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
There was a problem hiding this comment.
Changed the membership to public for Azure org and validated using the above script
|
@jsquire Addressed the comment, please let me know if there's anything else |
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.