Skip to content

Update Azure.ResourceManager.Resources API version to latest #50033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anthony-c-martin
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 02:44
@anthony-c-martin anthony-c-martin requested a review from a team as a code owner May 14, 2025 02:44
@github-actions github-actions bot added the ARM label May 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure.ResourceManager.Resources API version references in the autorest.md file and introduces several new overloads and property type changes across the ARM resource model APIs.

  • Updated API version URLs in autorest.md from 2024-11-01 to 2025-04-01 and added new input file references.
  • Introduced a new Identity property on ArmDeploymentContent and updated collection types (e.g. changing OutputResources and ValidatedResources from SubResource lists to ResourceReference lists) along with additional overloads for methods such as ArmDeploymentProperties and WhatIfChange.

Reviewed Changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.

File Description
sdk/resources/Azure.ResourceManager.Resources/src/autorest.md Updated API version strings and input file URLs to reflect the latest API version.
sdk/resources/Azure.ResourceManager.Resources/api/Azure.ResourceManager.Resources.netstandard2.0.cs Added new properties, overloads, and updated collection types as part of the API update.
sdk/resources/Azure.ResourceManager.Resources/api/Azure.ResourceManager.Resources.net8.0.cs Mirrored changes from netstandard2.0 with similar new overloads and property updates.
Comments suppressed due to low confidence (3)

sdk/resources/Azure.ResourceManager.Resources/api/Azure.ResourceManager.Resources.netstandard2.0.cs:1358

  • [nitpick] Multiple overloads of ArmDeploymentProperties are introduced with subtle differences; consider adding detailed XML documentation comments to clarify their intended usage and parameter differences.
public static Azure.ResourceManager.Resources.Models.ArmDeploymentProperties ArmDeploymentProperties(System.BinaryData template, Azure.ResourceManager.Resources.Models.ArmDeploymentTemplateLink templateLink, System.BinaryData parameters, ...)

sdk/resources/Azure.ResourceManager.Resources/api/Azure.ResourceManager.Resources.netstandard2.0.cs:1409

  • [nitpick] The addition of an extension parameter in the WhatIfChange overloads enhances functionality; please ensure that XML documentation is updated to clarify the scenarios where each overload should be used.
public static Azure.ResourceManager.Resources.Models.WhatIfChange WhatIfChange(string resourceId = null, string deploymentId = null, string symbolicName = null, System.BinaryData identifiers = null, Azure.ResourceManager.Resources.Models.DeploymentExtensionDefinition extension = null, ...)

sdk/resources/Azure.ResourceManager.Resources/api/Azure.ResourceManager.Resources.netstandard2.0.cs:1226

  • The change from IReadOnlyList to IReadOnlyList for OutputResources appears intentional; please ensure that corresponding client code and serialization logic are updated consistently.
public System.Collections.Generic.IReadOnlyList<Azure.ResourceManager.Resources.Models.ResourceReference> OutputResources { get { throw null; } }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant