[AutoPR Azure.ResourceManager.MongoDBAtlas]-generated-from-spec-gen-sdk - net-4864281 #50047
+217,861
−129,655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tspconfig.yaml', API Version: 2024-11-18-preview, SDK Release Type: beta, and CommitSHA: '18f9e9bfeeccb0f9a44c9902e8478fbe97d2c3c6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'
github-actions
bot
added
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
vikaschoudharycs097
requested review from
ArcturusZhang,
ArthurMa1978 and
jsquire
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR auto-generates the new MongoDBAtlas resource manager SDK with supporting CI/CD configurations, test scaffolding, API client classes, and documentation updates. Key changes include:
- Adding MongoDBAtlas pipeline triggers and a dedicated CI configuration file.
- Introducing source, test, and sample projects along with updated assembly and solution files.
- Adding API client classes and models for MongoDBAtlas resource management.
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/resourcemanager/ci.mgmt.yml | Updated CI trigger to include MongoDBAtlas. |
| sdk/mongodbatlas/ci.mgmt.yml | New CI configuration file for MongoDBAtlas with path definitions. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/tsp-location.yaml | Specifies the service location and spec repo for MongoDBAtlas. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/tests/*.cs | New test environment and base classes for MongoDBAtlas. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/src/* | New source files and project configuration for the MongoDBAtlas SDK. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/api/*.cs | Auto-generated API surface files for netstandard2.0 and net8.0. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/README.md | Added documentation and usage instructions for the new SDK. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/Directory.Build.props | New build properties file. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/CHANGELOG.md | Initial changelog for the beta release. |
| sdk/mongodbatlas/Azure.ResourceManager.MongoDBAtlas/Azure.ResourceManager.MongoDBAtlas.sln | Updated solution file to include new projects. |
| System.Collections.Generic.IEnumerator<Azure.ResourceManager.MongoDBAtlas.OrganizationResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.MongoDBAtlas.OrganizationResource>.GetEnumerator() { throw null; } | ||
| System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; } | ||
| } | ||
| public partial class OrganizationResourceData : Azure.ResourceManager.Models.TrackedResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MongoDBAtlas.OrganizationResourceData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.OrganizationResourceData> |
There was a problem hiding this comment.
this name is quite common, could we rename this to something like MongoDBAtlasOrganization?
To do this, you need to open a PR to make changes in your client.tsp to add some renaming clause such as:
@@clientName(OrganizationResource, "MongoDBAtlasOrganization", "csharp");and you could generate the library by using a local spec repo:
dotnet build /t:GenerateCode /p:LocalSpecRepo="absolutePathOfSpecRepo"
and during the review process, we will review both this PR and the corresponding spec PR.
When everything is ready, we will merge your spec PR for the client.tsp first, and then you could update the tsp-location.yaml file to the new commit id.
| string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.OfferDetails>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.OfferDetails>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| public partial class OrganizationProperties : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MongoDBAtlas.Models.OrganizationProperties>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.OrganizationProperties> |
There was a problem hiding this comment.
this name should follow the same pattern that we have made to OrganizationResource model.
| public static bool operator !=(Azure.ResourceManager.MongoDBAtlas.Models.MarketplaceSubscriptionStatus left, Azure.ResourceManager.MongoDBAtlas.Models.MarketplaceSubscriptionStatus right) { throw null; } | ||
| public override string ToString() { throw null; } | ||
| } | ||
| public partial class OfferDetails : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MongoDBAtlas.Models.OfferDetails>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.OfferDetails> |
There was a problem hiding this comment.
could this model have a more specific name as well?
| string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.OrganizationProperties>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.OrganizationProperties>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| public partial class PartnerProperties : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MongoDBAtlas.Models.PartnerProperties>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.PartnerProperties> |
There was a problem hiding this comment.
this name is also too generic, could we rename this to have a more specific name?
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.PartnerProperties>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | ||
| public readonly partial struct ResourceProvisioningState : System.IEquatable<Azure.ResourceManager.MongoDBAtlas.Models.ResourceProvisioningState> |
There was a problem hiding this comment.
We must rename this type to MongoDBAtlasProvisiningState.
| public static bool operator !=(Azure.ResourceManager.MongoDBAtlas.Models.ResourceProvisioningState left, Azure.ResourceManager.MongoDBAtlas.Models.ResourceProvisioningState right) { throw null; } | ||
| public override string ToString() { throw null; } | ||
| } | ||
| public partial class UserDetails : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.MongoDBAtlas.Models.UserDetails>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.MongoDBAtlas.Models.UserDetails> |
There was a problem hiding this comment.
this is also too generic and we should rename this to be a more specific name.
There was a problem hiding this comment.
this should be a mistake, please revert
ajaykumarmehra
force-pushed
the
sdkauto/Azure.ResourceManager.MongoDBAtlas-4864281
branch
from
4647152 to
4bf4ceb
Compare
* Update Generator Version 3.0.0-beta.20250514.2 * Update SDK codes co_da_1 * Update SDK codes ma_pr_4 * Update SDK codes ad_co_0 * Update SDK codes pu_sq_5
Co-authored-by: Patrick Hallisey <[email protected]>
) * cspell: Remove node version requirement, node is already on the agent * Succeeded --------- Co-authored-by: Daniel Jurek <[email protected]>
…ce (Azure#50036) * change the project reference of azure.provisioning to package reference * fix the issues of building * update for azure.core * add azure core to try to resolve the project reference replacer * fix the project reference replace issue * address pr feedback * remove orphaned prop * Update sdk/provisioning/Directory.Build.props Co-authored-by: Jesse Squire <[email protected]> --------- Co-authored-by: m-nash <[email protected]> Co-authored-by: Jesse Squire <[email protected]>
) * Allow for empty serviceDirectory in deploy-test-resources * Revert some unintentional changes * Restore missing comment --------- Co-authored-by: Patrick Hallisey <[email protected]>
* Add a new sample and re emit the code. * fixes
ajaykumarmehra
requested review from
JoshLove-msft,
m-nash,
jorgerangel-msft,
live1206,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft,
a team,
hallipr,
weshaggard,
benbp,
Ptnan7,
8Gitbrix,
Renyx1219,
ddadaal,
SahilArora92,
rahuls-microsoft,
banggaurav,
aggarwalsw,
quentinRobinson,
bidisha-c,
jhakulin,
nick863,
trangevi,
dargilco and
glharper
as code owners
jsquire
requested changes
May 23, 2025
There was a problem hiding this comment.
This pull request is not reviewable in the current form. Please rebase on main and ensure the only files included are those that you're intending to change. You should not be making changes to files outside of your /sdk directory other than to add yourself to CODEOWNERS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/liftrmongodb/MongoDB.Atlas.Management/tspconfig.yaml', API Version: 2024-11-18-preview, SDK Release Type: beta, and CommitSHA: '18f9e9bfeeccb0f9a44c9902e8478fbe97d2c3c6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'