-
Notifications
You must be signed in to change notification settings - Fork 5k
[Not ready for review] Karthikgumpu/nsp 2024 07 01 #50096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Not ready for review] Karthikgumpu/nsp 2024 07 01 #50096
Conversation
Co-authored-by: anu jain <[email protected]>
…j-prjwl/azure-sdk-for-net into karthikgumpu/nsp-2024-07-01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Application protection services list in the Network README, adding a new service and adjusting the list punctuation.
- Adds “Network Security Perimeter” to the protection services list
- Adjusts comma/hyphen usage in the inline list
Comments suppressed due to low confidence (1)
sdk/network/Azure.ResourceManager.Network/README.md:6
- 'Network Security Perimeter' is not a recognized Azure service; confirm the correct service name to ensure accuracy.
Application protection services: Protect your applications using any or a combination of these networking services in Azure - Load Balancer, Private Link, Network Security Perimeter, DDoS protection, Firewall, - Network Security Groups, Web Application Firewall, and Virtual Network Endpoints.
@@ -3,7 +3,7 @@ | |||
The networking services in Microsoft Azure provide a variety of networking capabilities that can be used together or separately. Key capabilities are: | |||
|
|||
- Connectivity services: Connect Azure resources and on-premises resources using any or a combination of these networking services in Azure - Virtual Network (VNet), Virtual WAN, ExpressRoute, VPN Gateway, Virtual network NAT Gateway, Azure DNS, Peering service, and Azure Bastion. | |||
- Application protection services: Protect your applications using any or a combination of these networking services in Azure - Load Balancer, Private Link, DDoS protection, Firewall, - Network Security Groups, Web Application Firewall, and Virtual Network Endpoints. | |||
- Application protection services: Protect your applications using any or a combination of these networking services in Azure - Load Balancer, Private Link, Network Security Perimeter, DDoS protection, Firewall, - Network Security Groups, Web Application Firewall, and Virtual Network Endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] There's an extra hyphen before 'Network Security Groups' in the comma-separated list; consider removing it or using semicolons for clarity.
- Application protection services: Protect your applications using any or a combination of these networking services in Azure - Load Balancer, Private Link, Network Security Perimeter, DDoS protection, Firewall, - Network Security Groups, Web Application Firewall, and Virtual Network Endpoints. | |
- Application protection services: Protect your applications using any or a combination of these networking services in Azure - Load Balancer, Private Link, Network Security Perimeter, DDoS protection, Firewall, Network Security Groups, Web Application Firewall, and Virtual Network Endpoints. |
Copilot uses AI. Check for mistakes.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.