Jimin/2025 ga #50191
Open
Jimin/2025 ga #50191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Chat service to v2025-03-15, adding thread‐level metadata and retention policy support across models, clients, tests, and documentation.
- Added
MetadataandRetentionPolicyto thread and participant models, factory methods, and request/response payloads - Introduced
CreateChatThreadOptionsandUpdateChatThreadPropertiesOptionstypes and corresponding client overloads - Expanded live and unit tests to cover metadata and retention policies, plus updated README and autorest config
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ChatClientsTests.cs | Added unit tests for thread retention policies |
| ChatClientsLiveTests.cs | Extended live tests to include metadata and retention |
| autorest.md | Bumped package tag and specs path to 2025-03-15 |
| Models/CreateChatThreadOptions.cs | New options type with metadata & retention properties |
| Models/UpdateChatThreadPropertiesOptions.cs | New properties options type |
| Models/ChatThreadProperties.cs | Added Metadata and RetentionPolicy properties |
| Models/ChatParticipant.cs | Added Metadata property and internal constructor |
| Models/ChatModelFactory.cs | Updated factory methods for metadata & retention |
| ChatThreadClient.cs | Added UpdateProperties overloads |
| ChatRestClient.cs | Switched to options overloads for thread creation |
| ChatClientOptions.cs | Updated to service version V2025_03_15 |
| ChatClient.cs | Overloaded CreateChatThread methods using options |
| README.md | Updated snippets and doc links for new features |
Comments suppressed due to low confidence (2)
sdk/communication/Azure.Communication.Chat/tests/ChatClients/ChatClientsTests.cs:1278
- The test
CreateChatThreadWithThreadRetentionPolicyShouldSucceedverifies the retention policy but does not assert thatchatThread.Metadatacontains the expected entries. Consider adding assertions for metadata to fully cover the new feature.
var threadCreationDateRetentionPolicy = chatThread.RetentionPolicy as ThreadCreationDateRetentionPolicy;
sdk/communication/Azure.Communication.Chat/README.md:404
- [nitpick] The links use
docs.microsoft.com, but the current standard islearn.microsoft.com. Updating tohttps://learn.microsoft.com/...ensures consistency with other Azure SDK docs.
[useraccesstokens]:https://docs.microsoft.com/azure/communication-services/quickstarts/access-tokens?pivots=programming-language-csharp
| /// <param name="deletedOn"> Deleted on date time </param> | ||
| /// <param name="metadata"> Property bag of chat thread metadata key - value pairs. </param> | ||
| /// <returns>A new <see cref="Chat.ChatThreadProperties"/> instance for mocking.</returns> | ||
| public static ChatThreadProperties ChatThreadProperties(string id, string topic, DateTimeOffset createdOn, CommunicationIdentifier createdBy, DateTimeOffset deletedOn, IDictionary<string, string> metadata) => new ChatThreadProperties(id, topic, createdOn, createdBy, deletedOn); |
There was a problem hiding this comment.
This factory overload accepts a metadata parameter but calls a constructor that doesn't take metadata. You need to add or update a matching ChatThreadProperties constructor that accepts IDictionary<string, string> (and ideally RetentionPolicy).
Copilot uses AI. Check for mistakes.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2025_03_15 GA release.
Introduced feature comparing to V2024_03_07 GA release:
API spec for this release: https://github.com/LuChen-Microsoft/azure-rest-api-specs/blob/release-communication-chat-2025-03-15/specification/communication/data-plane/Chat/stable/2025-03-15/communicationserviceschat.json
Introduced feature is a subset of V2024_03_15_preview release:
The PR for the V2024_03_15_preview as reference: Added ACS Chat preview feature: introducing chat data retention as a thread property. by angiurgiu · Pull Request #42854 · Azure/azure-sdk-for-net
Test: