Make converter types public

[agocke]

In order to use source-generated JSON, the converter types need to be at least as accessible as the serialized types. This PR changes all public types which have converters to make those converters public.

[github-actions]

Thank you for your contribution @agocke! We will review the pull request and get back to you soon.

[Copilot]

Pull Request Overview

This PR makes JSON converter types public so they are as accessible as their associated serialized types, enabling source-generated JSON support.

• Changed converter classes from internal to public
• Added XML documentation comments for converters and their methods

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
sdk/resourcemanager/Azure.ResourceManager/src/Resources/Custom/ResourceProviderData.cs	Made ProviderDataConverter public and added docs
sdk/resourcemanager/Azure.ResourceManager/src/Resources/Custom/Models/WritableSubResource.Serialization.cs	Made WritableSubResourceConverter public and added docs
sdk/resourcemanager/Azure.ResourceManager/src/Resources/Custom/Models/SubResource.Serialization.cs	Made SubResourceConverter public and added docs
sdk/resourcemanager/Azure.ResourceManager/src/Common/Custom/Models/ManagedServiceIdentityType.cs	Made ManagedServiceIdentityTypeConverter public and added docs
sdk/resourcemanager/Azure.ResourceManager/src/Common/Custom/Models/ManagedServiceIdentity.Serialization.cs	Made ManagedServiceIdentityConverter public and added docs

Comments suppressed due to low confidence (2)

sdk/resourcemanager/Azure.ResourceManager/src/Resources/Custom/ResourceProviderData.cs:58

• Include XML tags for writer, providerData, and options parameters and a tag to ensure consistent and complete API documentation.

public override void Write(Utf8JsonWriter writer, ResourceProviderData providerData, JsonSerializerOptions options)

sdk/resourcemanager/Azure.ResourceManager/src/Resources/Custom/ResourceProviderData.cs:53

• Add unit tests to verify the serialization and deserialization behavior of this public converter to ensure JSON handling works as expected.

public partial class ProviderDataConverter : JsonConverter<ResourceProviderData>

[m-nash]

We should modify this to pass in a common instance of JsonSerializerOptions which uses https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/System.ClientModel/src/ModelReaderWriter/JsonModelConverter.cs and specifically calls the ctor that takes in AzureResourceManagerCostmosDBContext.Default

//internal helper somewhere
    internal readonly static JsonSerializerOptions s_options = new()
    {
        Converters =
        {
            new JsonModelConverter(ModelSerializationExtensions.WireOptions, AzureResourceManagerCosmosDBContext.Default)
        }
    };

//this line then becomes
JsonSerializer.Serialize(writer, Identity, s_options);