Update `Azure.ResourceManager.AppContainers` to `2025-02-02-preview` #50236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

najian wants to merge 2 commits into Azure:main from najian:naji/release-2025-02-02-preview

Member

najian commented May 23, 2025

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.


          Add 2025-02-02-preview SDK

adfd9db

Copilot AI review requested due to automatic review settings

May 23, 2025 06:47

najian requested review from ArcturusZhang and ArthurMa1978 as code owners

May 23, 2025 06:47

github-actions bot added the Mgmt label

Copilot AI reviewed

View reviewed changes

Contributor

Copilot AI left a comment

Pull Request Overview

Adds the 2025-02-02-preview version of the Container Apps SDK and adjusts the ContainerAppBillingMeterProperties class.

Removes the setter from the Category property
Makes Category read-only

...nerapps/Azure.ResourceManager.AppContainers/src/Custom/ContainerAppBillingMeterProperties.cs Show resolved Hide resolved

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      System.Collections.Generic.IEnumerator<Azure.ResourceManager.AppContainers.BuildResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppContainers.BuildResource>.GetEnumerator() { throw null; }

                      System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }

                  }

                  public partial class BuildResourceData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.BuildResourceData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.BuildResourceData>

Member

ArcturusZhang May 23, 2025

how should we comprehend a "BuildResource"?
I think we need to rename this, should this be AppBuild?

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
            @@ -186,8 +442,8 @@ protected ContainerAppConnectedEnvironmentCertificateResource() { }
          
                      Azure.ResourceManager.AppContainers.ContainerAppCertificateData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppCertificateData>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppCertificateData>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppCertificateData>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      public virtual Azure.Response<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentCertificateResource> Update(Azure.ResourceManager.AppContainers.Models.ContainerAppCertificatePatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }

                      public virtual System.Threading.Tasks.Task<Azure.Response<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentCertificateResource>> UpdateAsync(Azure.ResourceManager.AppContainers.Models.ContainerAppCertificatePatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }

                      public virtual Azure.ResourceManager.ArmOperation<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentCertificateResource> Update(Azure.WaitUntil waitUntil, Azure.ResourceManager.AppContainers.Models.ContainerAppCertificatePatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }

Member

ArcturusZhang May 23, 2025

here is a breaking change.
we should introduce the removed overload back.
its implementation could just call this new one.

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                  {

                      public static readonly Azure.Core.ResourceType ResourceType;

                      protected ContainerAppConnectedEnvironmentDaprComponentResource() { }

                      public virtual Azure.ResourceManager.AppContainers.ContainerAppDaprComponentData Data { get { throw null; } }

                      public virtual Azure.ResourceManager.AppContainers.ConnectedEnvironmentDaprComponentData Data { get { throw null; } }

Member

ArcturusZhang May 23, 2025

so we need to rename this model back

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
            @@ -311,7 +573,7 @@ protected ContainerAppConnectedEnvironmentStorageCollection() { }
          
                  public partial class ContainerAppConnectedEnvironmentStorageData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentStorageData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppConnectedEnvironmentStorageData>

                  {

                      public ContainerAppConnectedEnvironmentStorageData() { }

                      public Azure.ResourceManager.AppContainers.Models.ContainerAppAzureFileProperties ConnectedEnvironmentStorageAzureFile { get { throw null; } set { } }

                      public Azure.ResourceManager.AppContainers.Models.ConnectedEnvironmentStorageProperties Properties { get { throw null; } set { } }

Member

ArcturusZhang May 23, 2025

Emmm why would we have this change?

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      System.Collections.Generic.IEnumerator<Azure.ResourceManager.AppContainers.ContainerAppsBuildResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppContainers.ContainerAppsBuildResource>.GetEnumerator() { throw null; }

                      System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }

                  }

                  public partial class ContainerAppsBuildResourceData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.ContainerAppsBuildResourceData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppsBuildResourceData>

Member

ArcturusZhang May 23, 2025

if possible I think we should remove the word resource from this model

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      System.Collections.Generic.IEnumerator<Azure.ResourceManager.AppContainers.ContainerAppsPatchResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppContainers.ContainerAppsPatchResource>.GetEnumerator() { throw null; }

                      System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; }

                  }

                  public partial class ContainerAppsPatchResourceData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.ContainerAppsPatchResourceData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.ContainerAppsPatchResourceData>

Member

ArcturusZhang May 23, 2025

we should remove the word Resource from this model's name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                  }

                  [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]

                  public readonly partial struct ContainerAppAccessMode : System.IEquatable<Azure.ResourceManager.AppContainers.Models.ContainerAppAccessMode>

                  public readonly partial struct BuilderProvisioningState : System.IEquatable<Azure.ResourceManager.AppContainers.Models.BuilderProvisioningState>

Member

ArcturusZhang May 23, 2025

we should rename this to AppContainersBuilderProvisioningState

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                  [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]

                  public readonly partial struct ContainerAppActiveRevisionsMode : System.IEquatable<Azure.ResourceManager.AppContainers.Models.ContainerAppActiveRevisionsMode>

                  public readonly partial struct BuildProvisioningState : System.IEquatable<Azure.ResourceManager.AppContainers.Models.BuildProvisioningState>

Member

ArcturusZhang May 23, 2025

we should rename this to AppContainersBuildProvisioningState

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      public override string ToString() { throw null; }

                  }

                  public partial class ContainerAppAllowedPrincipals : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.ContainerAppAllowedPrincipals>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerAppAllowedPrincipals>

                  [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]

                  public readonly partial struct BuildStatus : System.IEquatable<Azure.ResourceManager.AppContainers.Models.BuildStatus>

Member

ArcturusZhang May 23, 2025

we should prepend the RP name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      public static bool operator !=(Azure.ResourceManager.AppContainers.Models.BuildStatus left, Azure.ResourceManager.AppContainers.Models.BuildStatus right) { throw null; }

                      public override string ToString() { throw null; }

                  }

                  public partial class BuildToken : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.BuildToken>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.BuildToken>

Member

ArcturusZhang May 23, 2025

same here

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs Outdated

    
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerExecutionStatus>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerExecutionStatus>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class ContainerRegistry : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.ContainerRegistry>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.ContainerRegistry>

Member

ArcturusZhang May 23, 2025

this name collides with the namespace of another RP, we should rename it.

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
            @@ -3729,6 +5217,18 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer
          
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EncryptionSettings>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EncryptionSettings>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class EnvironmentVariable : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.EnvironmentVariable>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EnvironmentVariable>

Member

ArcturusZhang May 23, 2025

we need to prepend something to this name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
            @@ -3742,6 +5242,222 @@ protected virtual void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter writer
          
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EventTriggerConfiguration>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.EventTriggerConfiguration>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class Header : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.Header>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.Header>

Member

ArcturusZhang May 23, 2025

this name only has one word, we need to specify.

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.Header>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.Header>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class HeaderMatch : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>

Member

ArcturusZhang May 23, 2025

we should also introduce a more specifc name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HeaderMatch>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class HttpConnectionPool : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>

Member

ArcturusZhang May 23, 2025

this is very likely to collide with system types, we need to specify its name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpConnectionPool>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class HttpGet : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpGet>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpGet>

Member

ArcturusZhang May 23, 2025

this is very likely to collide with system types, we need to specify its name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpGet>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpGet>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class HttpRetryPolicy : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>

Member

ArcturusZhang May 23, 2025

this is very likely to collide with core types, we need to specify its name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRetryPolicy>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class HttpRoute : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpRoute>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRoute>

Member

ArcturusZhang May 23, 2025

this is very likely to collide with system types, we need to specify its name

ArcturusZhang reviewed

View reviewed changes

...erapps/Azure.ResourceManager.AppContainers/api/Azure.ResourceManager.AppContainers.net8.0.cs

    
                      string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRouteConfigProperties>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                      System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRouteConfigProperties>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }

                  }

                  public partial class HttpRouteMatch : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.AppContainers.Models.HttpRouteMatch>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.AppContainers.Models.HttpRouteMatch>

Member

ArcturusZhang May 23, 2025

this is very likely to collide with system types, we need to specify its name

ArcturusZhang changed the title ~~Add 2025-02-02-preview SDK~~ Update Azure.ResourceManager.AppContainers to 2025-02-02-preview


          a few updates

b2163fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt