MPG migration - mongocluster #54639
Open
MPG migration - mongocluster #54639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyuazhang
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the mongocluster SDK to a new Management Plane Generator (MPG). The changes involve:
- Updating the emitter package configuration to use the new Azure TypeSpec HTTP client C# management emitter
- Regenerating all code using the new generator, which results in significant refactoring of the generated REST operations and resource classes
Key Changes:
- Migration from legacy emitter to
azure-typespec-http-client-csharp-mgmt-emitter-package.json - Removal of
additionalDirectoriesfield from tsp-location.yaml - Comprehensive refactoring of REST operations classes to use
RequestContextpattern - Parameter type changes from
stringtoGuidfor subscription IDs - Updated serialization patterns and class structure
Reviewed changes
Copilot reviewed 1 out of 149 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updates emitter package path and removes additionalDirectories field |
| UsersRestOperations.cs | Refactored to use new RequestContext pattern, removed async/sync method pairs |
| ReplicasRestOperations.cs | Simplified to core request creation methods with RequestContext |
| PrivateLinksRestOperations.cs | Streamlined to use new generator patterns |
| PrivateEndpointConnectionsRestOperations.cs | Refactored similar to other REST operations |
| MongoClustersRestOperations.cs | Major simplification using RequestContext approach |
| FirewallRulesRestOperations.cs | Updated to match new generator patterns |
| ProviderConstants.cs | Added XML documentation and partial keyword |
| MongoClusterUserResource.cs | Updated with new diagnostic scopes and request handling |
| MongoClusterUserData.cs | Simplified with new serialization patterns |
| MongoClusterUserCollection.cs | Refactored to use new pageable wrapper patterns |
| MongoClusterResource.cs | Extensive updates to match new generator architecture |
| Various Serialization files | Updated to use new serialization infrastructure |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Fixes #53885