Add support for KeepAlive updates in streaming system#56258
Open
wmmihaa wants to merge 1 commit intoAzure:mainfrom
Open
Add support for KeepAlive updates in streaming system#56258wmmihaa wants to merge 1 commit intoAzure:mainfrom
wmmihaa wants to merge 1 commit intoAzure:mainfrom
Conversation
Introduced a new `KeepAlive` update reason to signify active connections during streaming operations. Updated the `StreamingUpdateReason` enum and its serialization/deserialization logic to handle the new `KeepAlive` reason. Modified the `StreamingUpdate.FromEvent` method to return a `KeepAliveUpdate` instance when a keep-alive message is received. Added a new `KeepAliveUpdate` class to represent keep-alive signals within streaming updates. This class includes a static method to generate keep-alive updates and is fully documented. Improved code organization and added comments to ensure seamless integration of the `KeepAlive` update reason into the existing streaming update system.
wmmihaa
requested review from
dargilco,
glharper,
nick863 and
trangevi
as code owners
github-actions
bot
added
AI Model Inference
AI Projects
Community Contribution
|
Thank you for your contribution @wmmihaa! We will review the pull request and get back to you soon. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
This issue is also related to the bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to issue #55585 and #55561 where KeepAlive updates are not handled.
Introduced a new
KeepAliveupdate reason to signify active connections during streaming operations. Updated theStreamingUpdateReasonenum and its serialization/deserialization logic to handle the newKeepAlivereason.Modified the
StreamingUpdate.FromEventmethod to return aKeepAliveUpdateinstance when a keep-alive message is received.Added a new
KeepAliveUpdateclass to represent keep-alive signals within streaming updates. This class includes a static method to generate keep-alive updates and is fully documented.Improved code organization and added comments to ensure seamless integration of the
KeepAliveupdate reason into the existing streaming update system.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.