[Storage] Change content iterating in _download_async.py, add decompression live tests against compressed dataset
#39755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing decompress knob
vincenttran-msft
requested review from
annatisch,
jalauzon-msft and
weirongw23-msft
as code owners
|
API change check API changes are not detected in this pull request. |
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -46,8 +46,11 @@ | |||
| async def process_content(data: Any, start_offset: int, end_offset: int, encryption: Dict[str, Any]) -> bytes: | |||
| if data is None: | |||
| raise ValueError("Response cannot be None.") | |||
| await data.response.load_body() | |||
| content = cast(bytes, data.response.body()) | |||
| if not data.response.is_stream_consumed: | |||
There was a problem hiding this comment.
Not sure if this exists on old transports... --> therefore may need to do an attribute check instead (but start off with seeing if there is any other way without attribute check)
| await data.response.load_body() | ||
| content = cast(bytes, data.response.body()) | ||
| if not data.response.is_stream_consumed: | ||
| content = b"".join([d async for d in data]) |
There was a problem hiding this comment.
This is a good start-- then test against the 3 transports, then when those work test validate_content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response.load_body()andresponse.body()in_download_async.pyto access content, as this method does not respect thedecompressparam passed todownload_blobAPIif-elseblock was added to handle the general hotpath and thevalidate_content=Truepath (where the body would have been loaded previously for MD5 check)decompress=T/Fscenario.