Skip to content

Migrate to Prompty and move to Projects SDK #39840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Migrate to Prompty and move to Projects SDK #39840

wants to merge 6 commits into from

Conversation

YusakuNo1
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added AI AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference) labels Feb 24, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 24, 2025 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-projects

@dargilco
Copy link
Member

@YusakuNo1 thanks for this PR! Can you please split it into two separate PRs, since we have feature branches for the next release of each SDK. For Project SDK changes, please open a PR against branch feature/azure-ai-projects-beta8. For Inference SDK changes, please open a PR against branch feature/azure-ai-inference-beta10.

@YusakuNo1
Copy link
Member Author

@YusakuNo1 thanks for this PR! Can you please split it into two separate PRs, since we have feature branches for the next release of each SDK. For Project SDK changes, please open a PR against branch feature/azure-ai-projects-beta8. For Inference SDK changes, please open a PR against branch feature/azure-ai-inference-beta10.

Thanks! Let's discuss offline. Maybe we can keep Inference SDK for now, only update Projects SDK

YusakuNo1
YusakuNo1 commented Mar 12, 2025
View reviewed changes
sdk/ai/azure-ai-projects/azure/ai/projects/prompts/_patch.py Outdated
Comment on lines 15 to 16
from prompty import headless, InvokerFactory, Prompty
from prompty import load, prepare
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review feedback: move these 2 lines when the user tries to use
Solution: check prompty availablility from init.py . Code: https://github.com/YusakuNo1/azure-sdk-for-python/blob/users/daviwu/migrate-to-use-prompty/sdk/ai/azure-ai-projects/azure/ai/projects/prompts/__init__.py#L6-L12

sdk/ai/azure-ai-projects/setup.py Outdated
@@ -97,6 +97,7 @@
"isodate>=0.6.1",
"azure-core>=1.30.0",
"typing-extensions>=4.12.2",
"prompty",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review feedback: remove this, add to extras

Solution: removed and added to "extras"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dargilco dargilco dargilco left review comments

@trangevi trangevi Awaiting requested review from trangevi trangevi is a code owner

@jhakulin jhakulin Awaiting requested review from jhakulin jhakulin is a code owner

@luigiw luigiw Awaiting requested review from luigiw luigiw is a code owner

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference) AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YusakuNo1 @azure-sdk @dargilco