SipRouting trunk setting sdk changes. #39858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

merveprn merged 34 commits into release/communiction_phone_numbers_1.4.0b2 from v-pivamshi/feature/sip-settings-phone-numbers

Jul 31, 2025

Contributor

v-pivamshi commented Feb 25, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.


          SipRouting trunk setting sdk changes.

8d06900

github-actions bot added the Communication - Phone Numbers label

Collaborator

azure-sdk commented Feb 25, 2025 •

edited by github-actions bot

Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure-communication-phonenumbers

Contributor Author

v-pivamshi commented Feb 26, 2025

User Story 3920786: SDK Implementation: Python

Generated swagger.
Added api changes.

jiriburant reviewed

View reviewed changes

...communication-phonenumbers/azure/communication/phonenumbers/siprouting/_generated/_client.py Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...unication-phonenumbers/azure/communication/phonenumbers/siprouting/_generated/aio/_client.py Show resolved Hide resolved


          resoleved credential issue.

360e62d

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved


          resolved the comment.

b240ef4

v-dharmarajv marked this pull request as ready for review

March 17, 2025 16:47

v-dharmarajv requested review from Arazan, danielortega-msft, sofiar-msft and whisper6284 as code owners

March 17, 2025 16:47

jiriburant reviewed

View reviewed changes

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

jiriburant reviewed

View reviewed changes

...on-phonenumbers/azure/communication/phonenumbers/siprouting/aio/_sip_routing_client_async.py Outdated Show resolved Hide resolved

v-pivamshi and others added 2 commits

May 8, 2025 21:11


          Resolved the PR comments and build isues.

a3b213e


          Updated tests and recordings.

b3fbe65

Collaborator

azure-sdk commented May 9, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-phonenumbers

jiriburant added 5 commits

May 9, 2025 13:46


          Updated recordings.

5ce4d65


          Added new samples and updated old ones.

b74ffb5


          Changed trunk_health to health

9e10746


          Fixing comments and newlines.

bb3f037


          Fixing comment.

704774b

merveprn changed the base branch from main to release/azure-communication-phone-numbers-1.4.0b1

June 20, 2025 12:28

merveprn added 5 commits

June 20, 2025 16:31


          Merge branch 'release/azure-communication-phone-numbers-1.4.0b1' into…

… v-pivamshi/feature/sip-settings-phone-numbers


          Updated recordings

3b5a934


          Fixed the error caused by merge conflicts

55ef68d


          Fixed the error build error caused by development status

74c636d


          Fixed the error build error caused by pylint

91c8cb3

merveprn changed the base branch from release/azure-communication-phone-numbers-1.4.0b1 to release/communiction_phone_numbers_1.4.0b2

July 24, 2025 09:20

merveprn added 5 commits

July 24, 2025 11:25


          Merge branch 'release/communiction_phone_numbers_1.4.0b2' into v-piva…

17e6d3a

…mshi/feature/sip-settings-phone-numbers


          assets.json update

93868b0


          version update

113640b


          assets update

45ec9da


          updated release date

4eec543

sofiar-msft reviewed

View reviewed changes

...-communication-phonenumbers/azure/communication/phonenumbers/siprouting/_generated/_patch.py Show resolved Hide resolved

...ication-phonenumbers/azure/communication/phonenumbers/siprouting/_generated/models/_enums.py Show resolved Hide resolved

...nication-phonenumbers/azure/communication/phonenumbers/siprouting/_generated/aio/__init__.py Show resolved Hide resolved

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Outdated Show resolved Hide resolved

sdk/communication/azure-communication-phonenumbers/samples/siprouting/get_sip_domains_sample.py Outdated Show resolved Hide resolved

...ommunication-phonenumbers/azure/communication/phonenumbers/siprouting/_sip_routing_client.py Show resolved Hide resolved

sdk/communication/azure-communication-phonenumbers/test/test_sip_routing_client_domains.py Outdated Show resolved Hide resolved

aakanmu added 6 commits

July 29, 2025 22:14


          address PR comments: update domain tests, and fix comments and file n…

fd38020

…ames


          fixed failing tests

133cc99


          update assets

7ddfeb8


          update assets

3dd1963


          update assets

acc3eb2


          update assets.json

100041c

sofiar-msft approved these changes

View reviewed changes

merveprn merged commit bb8c11a into release/communiction_phone_numbers_1.4.0b2

18 checks passed

merveprn deleted the v-pivamshi/feature/sip-settings-phone-numbers branch

July 31, 2025 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aakanmu aakanmu left review comments

Arazan Awaiting requested review from Arazan Arazan is a code owner

whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

danielortega-msft Awaiting requested review from danielortega-msft danielortega-msft is a code owner

+3 more reviewers

merveprn merveprn left review comments

jiriburant jiriburant left review comments

sofiar-msft sofiar-msft approved these changes

Labels

Communication - Phone Numbers