Address all current pylint and mypy warnings #40103
Open
+762
−532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Evaluation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses existing pylint and mypy warnings and applies Black reformatting across the codebase. Key changes include updates to typing annotations and overload declarations, modifications to docstrings for consistency, and minor refactoring of type conversions and parameter hints.
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/* | Updated overload declarations with "# type: ignore[override]" and adjusted parameter annotations and docstrings. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_evaluate.py | Revised type hints (e.g. switching to ProxyClient) and improved numeric conversions with cast. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_common/math.py | Changed type annotations from List[float] to Sequence[float] for enhanced flexibility. |
| Others | Similar consistency changes to overloads, docstrings, and type hints are applied across evaluators. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses all pylint, and mypy warnings. This also runs tox -e black reformatting on the code base