Skip to content

[communication] pipeline #40294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[communication] pipeline #40294

wants to merge 1 commit into from

Conversation

l0lawrence
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@scbedd
Copy link
Member

scbedd commented Apr 3, 2025

/azp run prepare-pipelines

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence l0lawrence marked this pull request as ready for review April 14, 2025 15:01
@Copilot Copilot AI review requested due to automatic review settings April 14, 2025 15:01
Copilot
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • sdk/communication/azure-communication-sms/tests.int.yml: Language not supported
Comments suppressed due to low confidence (1)

sdk/communication/azure-communication-messages/tests.yml:18

  • [nitpick] Consider unifying the casing for boolean string values (e.g., using either 'True' or 'true') to ensure consistency with AZURE_TEST_RUN_LIVE.
AZURE_SKIP_LIVE_RECORDING: 'True'

sdk/communication/azure-communication-jobrouter/tests.yml
- $(sub-config-communication-services-cloud-test-resources-python)
Clouds: Public
EnvVars:
AZURE_SKIP_LIVE_RECORDING: 'True'
Copy link
Preview

Copilot AI Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider unifying the casing for boolean string values (e.g., using either 'True' or 'true') to ensure consistency with AZURE_TEST_RUN_LIVE.

Suggested change
AZURE_SKIP_LIVE_RECORDING: 'True'
AZURE_SKIP_LIVE_RECORDING: 'true'

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

kristapratico
kristapratico reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we trigger the pipelines we're creating here to make sure everything is hooked up?

@l0lawrence
Copy link
Member Author

l0lawrence commented Apr 14, 2025 •
edited
Loading

/azp run python - azure-communication-callautomation - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence
Copy link
Member Author

l0lawrence commented Apr 14, 2025 •
edited
Loading

/azp run python - azure-communication-email - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@l0lawrence
Copy link
Member Author

l0lawrence commented Apr 14, 2025 •
edited
Loading

/azp run python - azure-communication-jobrouter - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@l0lawrence
Copy link
Member Author

l0lawrence commented Apr 14, 2025 •
edited
Loading

/azp run python - azure-communication-sms - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence
Copy link
Member Author

/azp run python - azure-communication-messages - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico left review comments

Copilot code review Copilot Copilot left review comments

@Shamkh Shamkh Awaiting requested review from Shamkh Shamkh is a code owner

@gfeitosa-msft gfeitosa-msft Awaiting requested review from gfeitosa-msft gfeitosa-msft is a code owner

@besh2014 besh2014 Awaiting requested review from besh2014 besh2014 is a code owner

@phermanov-msft phermanov-msft Awaiting requested review from phermanov-msft phermanov-msft is a code owner

@ilyapaliakou-msft ilyapaliakou-msft Awaiting requested review from ilyapaliakou-msft ilyapaliakou-msft is a code owner

@dinazavyr dinazavyr Awaiting requested review from dinazavyr dinazavyr is a code owner

@sarkar-rajarshi sarkar-rajarshi Awaiting requested review from sarkar-rajarshi sarkar-rajarshi is a code owner

@yogeshmo yogeshmo Awaiting requested review from yogeshmo yogeshmo is a code owner

@minwoolee-msft minwoolee-msft Awaiting requested review from minwoolee-msft minwoolee-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Communication - Call Automation Communication - Email Communication - Job Router Communication - Messages Communication - SMS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@l0lawrence @azure-sdk @scbedd @kristapratico