-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding Throughput Bucket Header #40340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5fba97d
198e8ce
f810c42
4afa626
7362216
4f8aa50
ea44ada
88cbfd4
73b773f
419e374
7367548
d661dff
f8e3b3a
2864b4b
e05cb51
2dfd408
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -160,6 +160,10 @@ def __init__( # pylint: disable=too-many-statements | |
http_constants.HttpHeaders.IsContinuationExpected: False, | ||
} | ||
|
||
throughput_bucket = kwargs.pop('throughput_bucket', None) | ||
if throughput_bucket: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what if the value is 0? how does python handle it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the bucket id is between 1-5, it will either go to the corresponding bucket or be ignored based on if the user has set up their buckets. If its any other value like 0 or a number greater than 5 a bad request is thrown. |
||
self.default_headers[http_constants.HttpHeaders.ThroughputBucket] = throughput_bucket | ||
|
||
# Keeps the latest response headers from the server. | ||
self.last_response_headers: CaseInsensitiveDict = CaseInsensitiveDict() | ||
|
||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a changelog entry for this new feature.