Skip to content

Phonenumbers/reservations implementation #40377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Phonenumbers/reservations implementation #40377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
15e5910
WIP: generate client with latest spec, start public client implementa…
danielortega-msft Apr 3, 2025
6a1f4bc
create custom model for reservations, implement async client
danielortega-msft Apr 4, 2025
61d3e27
Add basic tests for phone numbers reservation management
danielortega-msft Apr 4, 2025
332b23d
Add missing public models
danielortega-msft Apr 4, 2025
7409e50
add missing tests
danielortega-msft Apr 4, 2025
99dd739
Update sanitizers for phonenumbers sdk
danielortega-msft Apr 8, 2025
511affc
Update tests and recordings for phone-numbers
danielortega-msft Apr 8, 2025
d7df45c
add convenience methods for updating phone numbers reservations
danielortega-msft Apr 9, 2025
310adc7
Update reservation constructor
danielortega-msft Apr 14, 2025
f24ecba
Address pylint issues
danielortega-msft Apr 14, 2025
0223e57
fix sphinx check
danielortega-msft Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-phonenumbers/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "python",
"TagPrefix": "python/communication/azure-communication-phonenumbers",
"Tag": "python/communication/azure-communication-phonenumbers_a45b7bec94"
"Tag": "python/communication/azure-communication-phonenumbers_db3a0ba22d"
}
28 changes: 27 additions & 1 deletion ...mmunication/azure-communication-phonenumbers/azure/communication/phonenumbers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,22 @@
OperatorInformationOptions,
OperatorInformation,
OperatorInformationResult,
PhoneNumbersBrowseRequest,
PhoneNumbersBrowseResult,
PhoneNumberBrowseCapabilitiesRequest,
AvailablePhoneNumber,
AvailablePhoneNumberCost,
AvailablePhoneNumberError,
)

from ._generated.models._enums import (
ReservationStatus,
AvailablePhoneNumberStatus,
)

from ._models import (
PhoneNumbersReservation,
PhoneNumbersReservationItem
)

__all__ = [
Expand All @@ -42,5 +58,15 @@
'OperatorInformationOptions',
'OperatorInformation',
'OperatorInformationResult',
'PhoneNumbersClient'
'PhoneNumbersClient',
'PhoneNumbersReservation',
'PhoneNumbersReservationItem',
'PhoneNumbersBrowseRequest',
'PhoneNumbersBrowseResult',
'PhoneNumberBrowseCapabilitiesRequest',
'AvailablePhoneNumber',
'AvailablePhoneNumberCost',
'AvailablePhoneNumberError',
'ReservationStatus',
'AvailablePhoneNumberStatus',
]
3 changes: 2 additions & 1 deletion ...cation/azure-communication-phonenumbers/azure/communication/phonenumbers/_api_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class ApiVersion(str, Enum, metaclass=CaseInsensitiveEnumMeta):
V2023_05_01_PREVIEW = "2023-05-01-preview"
V2024_03_01_PREVIEW = "2024-03-01-preview"
V2025_02_11 = "2025-02-11"
V2025_04_01 = "2025-04-01"


DEFAULT_VERSION = ApiVersion.V2025_02_11
DEFAULT_VERSION = ApiVersion.V2025_04_01
2 changes: 1 addition & 1 deletion ...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_generated/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class PhoneNumbersClient:
:param endpoint: The communication resource, for example
https://resourcename.communication.azure.com. Required.
:type endpoint: str
:keyword api_version: Api Version. Default value is "2025-02-11". Note that overriding this
:keyword api_version: Api Version. Default value is "2025-04-01". Note that overriding this
default value may result in unsupported behavior.
:paramtype api_version: str
:keyword int polling_interval: Default waiting time between two polls for LRO operations if no
Expand Down
4 changes: 2 additions & 2 deletions ...-communication-phonenumbers/azure/communication/phonenumbers/_generated/_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ class PhoneNumbersClientConfiguration: # pylint: disable=too-many-instance-attr
:param endpoint: The communication resource, for example
https://resourcename.communication.azure.com. Required.
:type endpoint: str
:keyword api_version: Api Version. Default value is "2025-02-11". Note that overriding this
:keyword api_version: Api Version. Default value is "2025-04-01". Note that overriding this
default value may result in unsupported behavior.
:paramtype api_version: str
"""

def __init__(self, endpoint: str, **kwargs: Any) -> None:
api_version: str = kwargs.pop("api_version", "2025-02-11")
api_version: str = kwargs.pop("api_version", "2025-04-01")

if endpoint is None:
raise ValueError("Parameter 'endpoint' must not be None.")
Expand Down
1 change: 1 addition & 0 deletions ...on/azure-communication-phonenumbers/azure/communication/phonenumbers/_generated/_patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Licensed under the MIT License.
# ------------------------------------


"""Customize generated code here.

Follow our quickstart for examples: https://aka.ms/azsdk/python/dpcodegen/python/customize
Expand Down
Loading
Loading