Skip to content

[EH] Disable Test for Py38 #40457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

kashifkhan
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 10, 2025 13:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/asynctests/test_websocket_exception_async.py:9

  • The test is disabled by commenting out its decorators and function definition. Consider using pytest.skip or the skip decorator so that the test runner reports it as skipped rather than silently omitting it.
# @pytest.mark.asyncio

sdk/eventhub/azure-eventhub/tests/pyamqp_tests/asynctests/test_websocket_async.py:35

  • Instead of commenting out the test entirely, using pytest.skip or the appropriate skip decorator is preferable to indicate that the test is intentionally skipped, improving test reporting.
# @pytest.mark.asyncio

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants