Skip to content

[monitor] Extend version range for psutil to include 7.x #40459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bartvanandel
Copy link

@bartvanandel bartvanandel commented Apr 10, 2025

Description

Extend the supported version range of psutil to include version 7.x. The only relevant breaking change (dropped support for Python 2.7) doesn't affect azure-sdk-for-python, which already requires Python 3.8+.

See https://github.com/giampaolo/psutil/blob/master/HISTORY.rst#700

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter labels Apr 10, 2025
Copy link

Thank you for your contribution @bartvanandel! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@bartvanandel bartvanandel changed the title Extend version range for psutil to include 7.x [monitor] Extend version range for psutil to include 7.x Apr 10, 2025
@bartvanandel
Copy link
Author

Should I just check off the tasks that don't really apply? A similar PR (#39354) was merged a while ago, having none of them checked.

@lzchen
Copy link
Member

lzchen commented Apr 12, 2025

@bartvanandel

Please rebase to the latest main to fix builds.

Support for Python 2.7 was dropped in psutil 7, but
azure-sdk-for-python requires Python 3.8+ anyway.
@bartvanandel bartvanandel force-pushed the fix/allow-psutil-7.x branch from 85408f2 to 6c872a5 Compare April 12, 2025 09:12
@bartvanandel
Copy link
Author

bartvanandel commented Apr 14, 2025

Please rebase to the latest main to fix builds.

@lzchen Done

Copy link
Member

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a CHANGELOG entry to indicate this change please.

@bartvanandel
Copy link
Author

LGTM. Please add a CHANGELOG entry to indicate this change please.

The same thing was done a while ago for this same package, there's no entry in CHANGELOG for that. I don't see any other such changes mentioned, can you suggest a template string to add? Fine by me as well if you change it in this PR directly, that will probably save both of us some time.

@bartvanandel
Copy link
Author

@microsoft-github-policy-service agree company="Millennity"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants