Skip to content

Use 1DP endpoint #40474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Use 1DP endpoint #40474

wants to merge 16 commits into from

Conversation

nick863
Copy link
Member

@nick863 nick863 commented Apr 11, 2025

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings April 11, 2025 05:14
@github-actions github-actions bot added the AI label Apr 11, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 138 out of 141 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • pylintrc: Language not supported
  • sdk/ai/azure-ai-assistants/MANIFEST.in: Language not supported
  • sdk/ai/azure-ai-assistants/apiview-properties.json: Language not supported
Comments suppressed due to low confidence (3)

sdk/ai/azure-ai-assistants/azure/ai/assistants/aio/_client.py:44

  • The _endpoint variable is assigned a literal '{endpoint}'. If this is intended as a URL template for substitution via the client's format_url method, please add a clarifying comment to avoid confusion.
        _endpoint = "{endpoint}"

sdk/ai/azure-ai-assistants/azure/ai/assistants/_client.py:42

  • The _endpoint variable is assigned a literal '{endpoint}'. If this is intended as a URL template for substitution via the client's format_url method, please add a clarifying comment to avoid confusion.
        _endpoint = "{endpoint}"

sdk/ai/azure-ai-assistants/azure/ai/assistants/_types.py:13

  • [nitpick] The duplicate 'str' type in the Union is redundant and may be removed for clearer type definitions.
AssistantsApiResponseFormatOption = Union[
    str,
    str,
    "_models.AssistantsApiResponseFormatMode",
    "_models.AssistantsApiResponseFormat",
    "_models.ResponseFormatJsonSchemaType",
]

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-assistants

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants