Skip to content

Remove Python 3.8 + Standardize on azsdk-pool on affected templates #40499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Apr 14, 2025

@LibbaLawrence this is the one that will merge. Wes didn't like the PYVERSION_X and I didn't really either :P

@msyyc can you please help me check this to ensure I don't break any of your use-cases?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 22 out of 27 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • eng/pipelines/templates/stages/platform-matrix.json: Language not supported
  • pyrightconfig.json: Language not supported
  • sdk/communication/azure-communication-phonenumbers/phonenumbers-livetest-matrix.json: Language not supported
  • sdk/cosmos/cosmos-emulator-matrix.json: Language not supported
  • sdk/cosmos/live-platform-matrix.json: Language not supported
Comments suppressed due to low confidence (1)

eng/pipelines/templates/jobs/smoke.tests.yml:84

  • The Windows matrix entries now reference $(LINUXPOOL) and $(LINUXVMIMAGE) which may be unintended for Windows jobs. Please confirm if a Windows-specific pool variable should be used instead.
              Pool: $(LINUXPOOL)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@msyyc
Copy link
Member

msyyc commented Apr 15, 2025

@scbedd I tested your changes locally and they work well. Since we also have PR #40396 to drop python 3.8 which seems have some conflicts with yours, please forgive me commit to your branch directly to resolve the conflict.

Copy link
Member

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scbedd
Copy link
Member Author

scbedd commented Apr 15, 2025

The failure in cosmos CI has nothing to do with this PR. It looks like a consistent specific test failing. Going to bypass that.

The single analyze failure from azure-core is also understood and caused by a separate pylint update. Going to merge this.

Thank you @msyyc for the merge + approval. I caught a couple remaining issues in archetype-python-release, but they were minor and I have since repaired them. Going to merge this thing before doing a final cleanup pass on all usage of the original pool names.

@scbedd scbedd merged commit 6b6a8c0 into main Apr 15, 2025
82 of 88 checks passed
@scbedd scbedd deleted the isolated-remove-py38 branch April 15, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants