-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove Python 3.8 + Standardize on azsdk-pool
on affected templates
#40499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…from livetest matrices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 22 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (5)
- eng/pipelines/templates/stages/platform-matrix.json: Language not supported
- pyrightconfig.json: Language not supported
- sdk/communication/azure-communication-phonenumbers/phonenumbers-livetest-matrix.json: Language not supported
- sdk/cosmos/cosmos-emulator-matrix.json: Language not supported
- sdk/cosmos/live-platform-matrix.json: Language not supported
Comments suppressed due to low confidence (1)
eng/pipelines/templates/jobs/smoke.tests.yml:84
- The Windows matrix entries now reference
$(LINUXPOOL) and $ (LINUXVMIMAGE) which may be unintended for Windows jobs. Please confirm if a Windows-specific pool variable should be used instead.
Pool: $(LINUXPOOL)
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The failure in The single Thank you @msyyc for the merge + approval. I caught a couple remaining issues in |
@LibbaLawrence this is the one that will merge. Wes didn't like the
PYVERSION_X
and I didn't really either :P@msyyc can you please help me check this to ensure I don't break any of your use-cases?