Fix toolcall error #40547
Open
Fix toolcall error #40547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Prompty as dependency * Ignore linters * Fix linter issues * Address PR review comments
This reverts commit 47eea99.
* [AI] [Projects] add latest TypeSpec commit * auto-genned code in PR branch * update custom code with openapi optional parameter * update openapi sample to use default_parameters param * add bing custom search tool definition * add bing custom search sample * mypy error * revert bad doc strings * fix tox sphinx * add content * revert operations upload_file methods * fix one lint issue * make default_parameter an optional * fix lint error - line too long * add type annotation to default_params * update snippets
* [AI] [Projects] List Threads operation commit from TypeSpec * generated code * show sample usage of list_threads API * add doc link for sample * review feedback
* Redesign automatic toolcalls * fix test
Image input support for assistants create message
* Fixes * Suppress Pylint errors
howieleung
requested review from
luigiw,
needuv,
paulshealy1,
singankit,
dargilco and
jhakulin
as code owners
dargilco
previously approved these changes
Apr 16, 2025
howieleung
commented
Apr 16, 2025
| @@ -734,7 +734,7 @@ def execute(self, tool_call: RequiredFunctionToolCall) -> Any: | |||
| try: | |||
| function, parsed_arguments = self._get_func_and_args(tool_call) | |||
| return function(**parsed_arguments) if parsed_arguments else function() | |||
| except TypeError as e: | |||
| except Exception as e: | |||
There was a problem hiding this comment.
Notes both execute function are only called by the following code:
for tool_call in tool_calls:
try:
if tool_call.type == "function":
tool = self.get_tool(FunctionTool)
output = tool.execute(tool_call)
tool_output = {
"tool_call_id": tool_call.id,
"output": output,
}
tool_outputs.append(tool_output)
except Exception as e: # pylint: disable=broad-exception-caught
tool_output = {"tool_call_id": tool_call.id, "output": str(e)}
tool_outputs.append(tool_output)
With that said, before this change, output field is the error message for non-TypeError exception. With this change all exceptions will cause the output to be {error = }
howieleung
changed the base branch from
feature/azure-ai-projects-beta9
to
main
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines