Have tool call accuracy return a valid response, rather than throw exception, when response has no tool calls #40684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and to align with other prompt templates
…ception, when response has no tool calls
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @JoseCSantos! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This pull request modifies the tool call accuracy evaluator to return an empty list instead of raising an exception when no tool calls are present and to adjust the aggregation logic for cases with no tool calls.
- Returns empty input rather than throwing an exception when response has no tool calls.
- Updates the aggregation logic to return a NaN score and a clear result message when no per-turn results exist.
Files not reviewed (1)
- sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_intent_resolution/intent_resolution.prompty: Language not supported
Comment on lines
+161
to
+162
| # return empty input when there are no tool calls. From a user perspective this is preferrable to raising an exception | ||
| # as the user will see explicitly the evaluator did not run, rather than seeing a null |
There was a problem hiding this comment.
Typo detected: 'preferrable' should be 'preferable'.
Suggested change
| # return empty input when there are no tool calls. From a user perspective this is preferrable to raising an exception | |
| # as the user will see explicitly the evaluator did not run, rather than seeing a null | |
| # return empty input when there are no tool calls. From a user perspective this is preferable to raising an exception |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines