[AutoRelease] t2-search-2025-04-27-45644(can only be merged by SDK owner)#40747
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the async operations for the Azure Search Management client by standardizing type annotations and import patterns while also removing the now‐unused OfferingsOperations module. Key changes include replacing deprecated sys version conditional imports with collections.abc usage, adding explicit type annotations for client configuration and serializer/deserializer instances, and updating default API version values and documentation.
Reviewed Changes
Copilot reviewed 107 out of 108 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_query_keys_operations.py | Updated imports and added type annotations in the init method. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_private_link_resources_operations.py | Similar updates with import replacements and added type annotations. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_private_endpoint_connections_operations.py | Replaced sys blocks and introduced type annotations. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_operations.py | Removed redundant sys version checks and added type annotations. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_offerings_operations.py | Removed the OfferingsOperations module. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/_network_security_perimeter_configurations_operations.py | Updated parameter descriptions to reflect “network security perimeter configuration” naming. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/init.py | Removed OfferingsOperations from the exports. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/aio/_search_management_client.py | Updated client initialization with new default API version and removed OfferingsOperations property. |
| sdk/search/azure-mgmt-search/azure/mgmt/search/_version.py, _configuration.py, README.md, CHANGELOG.md | Updated version information, default API version, and Python version requirements. |
Files not reviewed (1)
- sdk/search/azure-mgmt-search/_meta.json: Language not supported
Comments suppressed due to low confidence (2)
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/operations/init.py:16
- OfferingsOperations has been removed from the exports. Please ensure that any documentation or test cases referencing this module are updated accordingly.
from ._offerings_operations import OfferingsOperations # type: ignore
sdk/search/azure-mgmt-search/azure/mgmt/search/aio/_search_management_client.py:118
- The offerings property has been removed from the client initialization. Verify that all consumers and related documentation are updated to account for the removal.
self.offerings = OfferingsOperations(self._client, self._config, self._serialize, self._deserialize)
|
Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
https://github.com/Azure/sdk-release-request/issues/6107
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1027
BuildTargetingString
azure-mgmt-search
Skip.CreateApiReview