Feature/azure ai agents v1 #40818
Open
Feature/azure ai agents v1 #40818
+57,446
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix unit tests * Record instrumentor tests
Fix static analysis, updates from azure sdk reviews. --------- Co-authored-by: nick863 <[email protected]>
* max retry and tests * fix test
howieleung
requested review from
l0lawrence,
luigiw,
needuv,
paulshealy1 and
singankit
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request implements version 1.0.0b1 of the Azure AI Agents SDK by introducing both asynchronous and synchronous client implementations, updated configuration and type definitions, and documentation for the new FunctionTool feature.
- Added asynchronous client support with proper request pipeline handling.
- Introduced synchronous client counterparts and updated configuration modules.
- Provided type definitions and FunctionTool specification documentation along with the initial changelog.
Reviewed Changes
Copilot reviewed 154 out of 158 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-agents/azure/ai/agents/aio/operations/init.py | Exports async operations. |
| sdk/ai/azure-ai-agents/azure/ai/agents/aio/_configuration.py | Adds configuration for the async client. |
| sdk/ai/azure-ai-agents/azure/ai/agents/aio/_client.py | Implements async client with pipeline request handling. |
| sdk/ai/azure-ai-agents/azure/ai/agents/init.py | Sets up package exports for async usage. |
| sdk/ai/azure-ai-agents/azure/ai/agents/_version.py | Defines the SDK version. |
| sdk/ai/azure-ai-agents/azure/ai/agents/_utils/utils.py | Provides utility functions for multipart form data. |
| sdk/ai/azure-ai-agents/azure/ai/agents/_types.py | Introduces common type definitions for SDK operations. |
| sdk/ai/azure-ai-agents/azure/ai/agents/_configuration.py | Updates synchronous client configuration. |
| sdk/ai/azure-ai-agents/azure/ai/agents/_client.py | Implements the sync client with request formatting. |
| sdk/ai/azure-ai-agents/azure/ai/agents/init.py | Sets up package exports for sync usage. |
| sdk/ai/azure-ai-agents/azure/ai/init.py, sdk/ai/azure-ai-agents/azure/init.py | Enable package path extension support. |
| sdk/ai/azure-ai-agents/FunctionTool.md | Adds documentation and examples for the FunctionTool feature. |
| sdk/ai/azure-ai-agents/CHANGELOG.md | Introduces the initial version changelog. |
Files not reviewed (4)
- pylintrc: Language not supported
- sdk/ai/azure-ai-agents/MANIFEST.in: Language not supported
- sdk/ai/azure-ai-agents/apiview-properties.json: Language not supported
- sdk/ai/azure-ai-agents/assets.json: Language not supported
Comments suppressed due to low confidence (1)
sdk/ai/azure-ai-agents/azure/ai/agents/_types.py:15
- Remove duplicate 'str' in the union type for AgentsApiToolChoiceOption to simplify the definition.
AgentsApiToolChoiceOption = Union[str, str, '_models.AgentsApiToolChoiceOptionMode', '_models.AgentsNamedToolChoice']
| AgentsApiToolChoiceOption = Union[str, str, "_models.AgentsApiToolChoiceOptionMode", "_models.AgentsNamedToolChoice"] | ||
| AgentsApiResponseFormatOption = Union[ | ||
| str, | ||
| str, |
There was a problem hiding this comment.
Remove duplicate 'str' in the union type for AgentsApiResponseFormatOption to improve clarity.
Suggested change
| str, |
Copilot uses AI. Check for mistakes.
|
|
||
| def __init__( | ||
| self, endpoint: str, credential: Union[AzureKeyCredential, "AsyncTokenCredential"], **kwargs: Any | ||
| ) -> None: |
There was a problem hiding this comment.
[nitpick] Consider adding a comment to clarify that the '{endpoint}' placeholder in _endpoint is intended for later substitution via the request formatting mechanism.
Suggested change
| ) -> None: | |
| ) -> None: | |
| # Placeholder for the endpoint URL, intended for substitution via the request formatting mechanism. |
Copilot uses AI. Check for mistakes.
| :paramtype api_version: str | ||
| """ | ||
|
|
||
| def __init__(self, endpoint: str, credential: Union[AzureKeyCredential, "TokenCredential"], **kwargs: Any) -> None: |
There was a problem hiding this comment.
[nitpick] Consider adding a comment to clarify that the '{endpoint}' placeholder in _endpoint is used for dynamic URL formatting in the pipeline.
Suggested change
| def __init__(self, endpoint: str, credential: Union[AzureKeyCredential, "TokenCredential"], **kwargs: Any) -> None: | |
| def __init__(self, endpoint: str, credential: Union[AzureKeyCredential, "TokenCredential"], **kwargs: Any) -> None: | |
| # The '{endpoint}' placeholder is used for dynamic URL formatting in the pipeline. |
Copilot uses AI. Check for mistakes.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
* update samples csv data * add cspell
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
* [AI] [Agents] tool changes for Bing tools and Azure AI Search * add implementation for abstract tool methods
* naming changes * update tests * Record the tests and disable azue functions for now (#40852) * Nirovins/record tests (#40854) * Record the tests and disable azue functions for now * Add recordings for azure functions * Record instrumentation tests --------- Co-authored-by: Jarno Hakulinen <[email protected]> --------- Co-authored-by: Nikolay Rovinskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines