-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add Conda release metadata to all stable SDK pyproject.tomls #44674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Conda release metadata to pyproject.toml files for all stable (non-management) SDK packages to specify whether they should be released to Conda individually or as part of a bundle. The metadata will be enforced by CI to ensure all stable packages have this configuration.
Changes:
- Added
[tool.azure-sdk-conda]sections to 57 pyproject.toml files - Packages are configured as either individual releases (
in_bundle = false) or bundle releases (in_bundle = truewithbundle_namespecified) - Created new pyproject.toml files for 8 packages that didn't previously have them
Reviewed changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/*/pyproject.toml (49 updated) | Added Conda metadata section to existing pyproject.toml files |
| sdk/*/pyproject.toml (8 created) | Created new pyproject.toml files with Conda metadata for packages without existing configuration |
|
What's this PR for? |
|
To any codeowners of the affected packages. These Going to bypass review requirements and merge on "EngSys needs this" basis here. |
|
@xiangyan99 I'm working on entirely automating the conda release process. this lets us make service teams tell us whether their packages should be released in a bundle or individually, which is necessary info for the automation |
Conda packages have their own packaging/versioning strategies and release timelines compared to the individual libraries. How are you thinking about handling that? |
Took offline. |
related to #44592
updates pyproject.tomls for packages that
for individually released packages:
example of bundle:
all stable release packages will be expected to set this metadata in their pyproject.toml, and it will be enforced in CI
summary of pyproject.toml updates:
edge case notes: