Add evaluation sample recording tests (first set) #44753
+126
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test_samples_evaluations.py with custom preparer and LLM instructions - Add UTF-8 encoding fix to sample_executor.py for Windows compatibility - Add azure_ai_agent_name to servicePreparer in test_base.py - Update assets.json with new recording tag
- sample_model_evaluation.py - sample_agent_response_evaluation.py - sample_evaluations_builtin_with_dataset_id.py - sample_evaluations_builtin_with_inline_data.py
- Add sanitizer for eval dataset timestamp (eval-data-YYYY-MM-DD_HHMMSS_UTC) - Remove sample_evaluations_builtin_with_dataset_id from tests (requires blob storage upload which doesn't work in playback) - All 4 evaluation samples now pass in playback mode
aprilk-ms
requested review from
dargilco,
glharper,
howieleung,
kingernupur,
nick863,
trangevi and
trrwilson
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds recording tests for evaluation samples, enabling automated testing of evaluation-related sample code. It introduces infrastructure for testing evaluation samples that require agent configuration and adds necessary sanitization patterns for evaluation-specific data in test recordings.
Changes:
- Added a new test class
TestSamplesEvaluationsto test evaluation samples with recording support - Enhanced sample executor with UTF-8 encoding for log file writing
- Extended test infrastructure with azure_ai_agent_name parameter for evaluation samples
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-projects/tests/samples/test_samples_evaluations.py | New test file for evaluation samples with custom validation instructions and test configuration for 4 evaluation samples |
| sdk/ai/azure-ai-projects/tests/samples/sample_executor.py | Added explicit UTF-8 encoding to file writing operation for better cross-platform compatibility |
| sdk/ai/azure-ai-projects/tests/test_base.py | Added azure_ai_agent_name parameter to servicePreparer for evaluation sample tests |
| sdk/ai/azure-ai-projects/tests/conftest.py | Added regex sanitizer for eval dataset names with timestamps to ensure consistent test recordings |
| sdk/ai/azure-ai-projects/assets.json | Updated test recording asset tag to reference new recordings |
Added: - sample_eval_catalog.py - sample_eval_catalog_code_based_evaluators.py - sample_eval_catalog_prompt_based_evaluators.py - sample_evaluation_compare_insight.py - sample_agent_response_evaluation_with_function_tool.py Skipped sample_evaluations_builtin_with_inline_data_oai.py (uses direct OpenAI client with get_bearer_token_provider which doesn't work with mock credentials)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines