Fix mypy 1.19.1 type errors in azure-developer-loadtesting #44756
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type annotations for _status, _termination_statuses, _polling_interval in LoadTestingPollingMethod and AsyncLoadTestingPollingMethod base classes - Add type conversion for body parameter in begin_upload_test_file to handle Union[IO, bytes] -> bytes conversion Co-authored-by: mitsha-microsoft <[email protected]>
Copilot
AI
changed the title
[WIP] Update typing updates for azure-developer-loadtesting with mypy 1.19.1
Fix mypy 1.19.1 type errors in azure-developer-loadtesting
Jan 19, 2026
| class LoadTestingPollingMethod(PollingMethod): | ||
| """Base class for custom sync polling methods.""" | ||
|
|
||
| _status: Optional[str] |
Member
There was a problem hiding this comment.
@copilot Can you take a look at the file and the properties you added, and check if we need to make any changes to existing properties and use the new properties you added if needed anywhere? If not, what will be the use of these properties?
Contributor
Author
There was a problem hiding this comment.
Good catch! I've added type annotations for the remaining base class attributes (_resource, _command, _initial_response) to be consistent.
These properties serve the same purpose as the ones I initially added: they're used in base class methods (like initialize(), _update_resource(), resource()) but initialized in child classes. Declaring them in the base class helps mypy understand the class structure.
Commit: fca44bd
Added type annotations for _resource, _command, and _initial_response to be consistent with other base class attributes that are initialized in child classes Co-authored-by: mitsha-microsoft <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot : Even after the fixes made, I am getting the following error for |
Changed _status, _resource, _command, and _initial_response from Optional to non-Optional types since they are always initialized before use in child classes Co-authored-by: mitsha-microsoft <[email protected]>
Contributor
Author
... Fixed! The issue was that I incorrectly marked Changed them to non-Optional types since:
This resolves all the mypy errors about "None not callable", incompatible return types, and non-indexable values. Commit: 83ca311 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Member
|
@copilot Can you check the fixes you made, really think hard, see what's going wrote, go through deeper in the class structure and make the correct fix ? |
The attributes are initialized to None in child __init__, then set to actual values by initialize() method. Using Optional types with assertions at usage points correctly reflects this lifecycle and satisfies mypy Co-authored-by: mitsha-microsoft <[email protected]>
Contributor
Author
Fixed! The issue was understanding the object lifecycle:
The correct solution is:
This properly reflects the runtime behavior and satisfies mypy's type checking without breaking the existing initialization pattern. Commit: 56b6665 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed all mypy errors in azure-developer-loadtesting for compatibility with mypy 1.19.1:
Changes:
__init__, then set byinitialize()Files Modified:
azure/developer/loadtesting/_operations/_patch.py(sync version)azure/developer/loadtesting/aio/_operations/_patch.py(async version)Object Lifecycle:
__init__sets attributes to NoneLROPollercallsinitialize()which sets them to actual valuesThis approach correctly reflects the actual runtime behavior and satisfies mypy's type checking.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.