Skip to content

Conversation

@vincenttran-msft
Copy link
Member

@vincenttran-msft vincenttran-msft commented Dec 9, 2025

.tsp: Azure/azure-rest-api-specs#39178

TODO:

  • Changelog

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Dec 9, 2025
@vincenttran-msft vincenttran-msft changed the title [Storage] initial v0.30.0 code generation [Storage] Snapshot and Versioning Blob Support Dec 10, 2025
@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure_storage_blob

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds snapshot and versioning support for Azure Storage blobs, introducing two new convenience methods with_snapshot() and with_version_id() to BlobClient. It also fixes query parameter ordering issues that were causing test failures.

Key Changes

  • Implemented snapshot and blob versioning functionality with convenience methods for creating version-specific and snapshot-specific blob clients
  • Fixed query parameter replacement behavior to ensure proper handling when options override client-level parameters
  • Removed test workarounds and re-enabled previously ignored tests that were failing due to query parameter ordering issues

Reviewed changes

Copilot reviewed 12 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/storage/azure_storage_blob/src/clients/blob_client.rs Added with_version_id(), with_snapshot(), and create_snapshot() methods to BlobClient
sdk/storage/azure_storage_blob/src/models/mod.rs Exported BlobClientCreateSnapshotOptions for public API usage
sdk/storage/azure_storage_blob/src/generated/models/header_traits.rs Updated generated code to remove date() method from BlobClientCreateSnapshotResultHeaders
sdk/storage/azure_storage_blob/src/generated/clients/blob_client.rs Updated generated documentation for create_snapshot method
sdk/storage/azure_storage_blob/tests/blob_client.rs Added comprehensive tests for versioning and snapshot features (8 new test functions)
sdk/storage/azure_storage_blob/tests/blob_container_client.rs Removed query ordering workarounds now that the underlying issue is fixed
sdk/storage/azure_storage_blob/tests/page_blob_client.rs Re-enabled test_upload_page_from_url test
sdk/storage/azure_storage_blob/tests/block_blob_client.rs Re-enabled test_upload_blob_from_url test
sdk/storage/azure_storage_blob/tests/blob_service_client.rs Re-enabled test_find_blobs_by_tags_service test
sdk/storage/azure_storage_blob/CHANGELOG.md Documented new snapshot and versioning support
sdk/storage/azure_storage_blob/tsp-location.yaml Updated TypeSpec specification commit reference
sdk/storage/azure_storage_blob/assets.json Updated test recording asset tag
sdk/eventhubs/azure_messaging_eventhubs_checkpointstore_blob/tests/checkpoint_unit_tests.rs Added temporary query ordering matcher for one test
sdk/eventhubs/assets.json Updated test recording asset tag for eventhubs
eng/emitter-package.json Fixed trailing newline
eng/emitter-package-lock.json Updated package dependencies to remove peer-only designations
Files not reviewed (1)
  • eng/emitter-package-lock.json: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Un-ignore query parameter ordering for record matching

2 participants