Skip to content

[azsdkcli] add next steps#11747

Merged
l0lawrence merged 5 commits into
Azure:mainfrom
l0lawrence:response_error_next_steps
Aug 26, 2025
Merged

[azsdkcli] add next steps#11747
l0lawrence merged 5 commits into
Azure:mainfrom
l0lawrence:response_error_next_steps

Conversation

@l0lawrence
Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Aug 20, 2025
Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs
Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs Outdated
Copy link
Copy Markdown
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me except a nit suggestion about NEXT STEPS output.

@l0lawrence l0lawrence marked this pull request as ready for review August 22, 2025 17:41
Copilot AI review requested due to automatic review settings August 22, 2025 17:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for displaying next steps in the Azure SDK CLI response model. The primary purpose is to provide users with actionable guidance after receiving responses from CLI operations.

  • Adds a new NextSteps property to the Response class for storing next steps information
  • Updates the ToString method to display next steps alongside error messages
  • Refactors the ToString method to use a more generic "messages" variable instead of "errors" to accommodate both error and next steps content

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs
Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs
Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs Outdated
Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs
Copy link
Copy Markdown
Member

@timovv timovv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think this idea of having actionable steps to take is a good one and will help people through the process

@maririos
Copy link
Copy Markdown
Member

maririos commented Aug 22, 2025

Understanding the flow: does this means that each tool will be responsible for managing the next steps?
or is there a "source of truth" on the steps that each tool references?

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs
Copy link
Copy Markdown
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to start adding in XML doc comments for these things, especially fields that are just wide open with what gets put into them.

"What's the expected output when I fill this in, and why should I use it?"

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Models/Responses/Response.cs
@richardpark-msft
Copy link
Copy Markdown
Member

I'm approving, but @samvaity's comments point to us wanting to have some more workable examples to look at.

Given the examples from the other chat, it looks like this is primarily about enhancing error messages, or (sometimes) trying to get the user to a next step that has docs and (probably) stuff they need to read. From talking with @l0lawrence, I think the main goal is that we blanket the user with all the info they need to get from one step to another, and stuff like this can keep them in the chat session (if that's where they started), or the CLI, if they work there.

@l0lawrence l0lawrence merged commit 1be18a7 into Azure:main Aug 26, 2025
13 checks passed
danieljurek pushed a commit that referenced this pull request Aug 29, 2025
* next steps

* next step as string

* next step update

* documentation

* this
radhgupta pushed a commit to radhgupta/azure-sdk-tools that referenced this pull request Sep 9, 2025
* next steps

* next step as string

* next step update

* documentation

* this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants