Skip to content

Alternative for PR search#11821

Closed
shirelmr wants to merge 21 commits into
mainfrom
explore2025-issue11778
Closed

Alternative for PR search#11821
shirelmr wants to merge 21 commits into
mainfrom
explore2025-issue11778

Conversation

@shirelmr
Copy link
Copy Markdown
Contributor

@shirelmr shirelmr commented Aug 25, 2025

Modified code for these issues.
#11778

Copilot AI review requested due to automatic review settings August 25, 2025 21:07
@github-actions github-actions Bot added the azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli label Aug 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces branch discovery logic that relied on searching pull requests by title with a direct PR number-based approach. The change eliminates complex search algorithms that could fail when multiple PRs contained similar keywords in their titles.

  • Replaced --branch option with --pr-number option for both update and validate commands
  • Removed complex PR search logic that matched titles against service labels or paths
  • Simplified branch resolution to directly fetch PR details using the provided PR number

shirelmr and others added 2 commits August 25, 2025 14:14
…ls/CodeownersTools.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ls/CodeownersTools.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@shirelmr shirelmr marked this pull request as draft August 26, 2025 17:02
@shirelmr shirelmr marked this pull request as ready for review August 26, 2025 20:44
@shirelmr shirelmr requested a review from benbp August 27, 2025 18:44
Copy link
Copy Markdown
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'd like to do a round of practical testing before approving.

@danieljurek
Copy link
Copy Markdown
Member

Practical testing reveals that the token issued to the GH CLI does NOT Have permission to push commits to forked repos via the API.

Possible solutions:

  1. Put changes on the filesystem and let other parts of the system push OR
  2. Clone (possibly sparse) in a temporary location, commit, push via the user's global git credentials (only works locally)

Comment thread tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/GitHubService.cs
Co-authored-by: Daniel Jurek <djurek@microsoft.com>

if (!hasPushPermissions)
{
resultMessages.Add($"GitHub token does not have permission to push to {repoOwner} repository, opening a new PR on a branch in the main repo");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand this message. The user can't create a PR so the tool is going to create it for them?

@github-actions
Copy link
Copy Markdown

Hi @shirelmr. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Nov 14, 2025
@github-actions
Copy link
Copy Markdown

Hi @shirelmr. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions Bot closed this Nov 21, 2025
@ronniegeraghty ronniegeraghty added the AzSDK Tools Agent Issue related to the AzSDK Tools Agent. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AzSDK Tools Agent Issue related to the AzSDK Tools Agent. azsdk-cli Issues related to Azure/azure-sdk-tools::tools/azsdk-cli no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants