Alternative for PR search#11821
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces branch discovery logic that relied on searching pull requests by title with a direct PR number-based approach. The change eliminates complex search algorithms that could fail when multiple PRs contained similar keywords in their titles.
- Replaced
--branchoption with--pr-numberoption for both update and validate commands - Removed complex PR search logic that matched titles against service labels or paths
- Simplified branch resolution to directly fetch PR details using the provided PR number
…ls/CodeownersTools.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ls/CodeownersTools.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
danieljurek
left a comment
There was a problem hiding this comment.
This looks good to me. I'd like to do a round of practical testing before approving.
|
Practical testing reveals that the token issued to the GH CLI does NOT Have permission to push commits to forked repos via the API. Possible solutions:
|
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
|
|
||
| if (!hasPushPermissions) | ||
| { | ||
| resultMessages.Add($"GitHub token does not have permission to push to {repoOwner} repository, opening a new PR on a branch in the main repo"); |
There was a problem hiding this comment.
not sure I understand this message. The user can't create a PR so the tool is going to create it for them?
|
Hi @shirelmr. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @shirelmr. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Modified code for these issues.
#11778