[azsdk-cli] Add open telemetry#11934
Merged
Merged
Conversation
benbp
added
Central-EngSys
praveenkuttappan
approved these changes
Sep 3, 2025
benbp
requested review from
jeo02,
l0lawrence,
maririos,
richardpark-msft,
samvaity,
scbedd,
smw-ms and
timovv
as code owners
Member
Author
|
Going to update the console exporter to only log out for debug mode (or even hide it behind another flag), then I'll merge |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds OpenTelemetry instrumentation to the azsdk-cli tool to enable distributed tracing and observability. The implementation replaces the existing custom TelemetryService with proper OpenTelemetry activities and spans.
Key changes:
- Replaced custom TelemetryService with OpenTelemetry activities and instrumentation
- Added OpenTelemetry package dependencies and configuration
- Implemented activity-based tracing for tool invocations with proper error handling
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TelemetryWrapper.cs | Replaced custom telemetry calls with OpenTelemetry activities and span instrumentation |
| ExampleTool.cs | Fixed namespace reference for Azure.Core.TokenRequestContext |
| TelemetryService.cs | Removed entire custom telemetry service implementation |
| Program.cs | Added OpenTelemetry service registration and configuration |
| TelemetryProcessor.cs | Added custom telemetry processor for post-processing activities |
| Constants.cs | Added activity source constant and removed unused import |
| Azure.Sdk.Tools.Cli.csproj | Added OpenTelemetry package references |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.