Fix json schema for update sdk details input so serialization does no…#11957
Merged
praveenkuttappan merged 4 commits intoSep 3, 2025
Merged
Conversation
praveenkuttappan
requested review from
benbp,
jeo02,
l0lawrence,
maririos,
richardpark-msft,
samvaity,
scbedd,
smw-ms and
timovv
as code owners
github-actions
Bot
added
the
azsdk-cli
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a JSON deserialization issue in the Azure SDK release plan tool where incoming JSON schema uses different property casing than expected. The fix ensures that both camelCase (language, packageName) and PascalCase (Language, PackageName) property names are properly handled during deserialization.
- Adds JSON property name attributes to the SDKInfo model for consistent serialization
- Implements string replacement logic to normalize property casing before deserialization
- Adds test coverage to verify the fix works with both casing formats
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ReleasePlanTool.cs | Adds string replacement logic to normalize JSON property casing and updates method documentation |
| ReleasePlanDetails.cs | Adds JsonPropertyName attributes to SDKInfo properties for consistent JSON serialization |
| ReleasePlanToolTests.cs | Adds test case to verify the fix handles both camelCase and PascalCase JSON inputs |
scbedd
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incoming JSON schema from GitHub copilot has
languageandpackageNameas properties and this causes failure when deserializing it and language and package name are empty for all objects.