Add pr link validation for get_release_plan_for_spec_pr#11984
Merged
Conversation
smw-ms
requested review from
benbp,
jeo02,
l0lawrence,
maririos,
praveenkuttappan,
richardpark-msft,
samvaity,
scbedd and
timovv
as code owners
github-actions
Bot
added
the
azsdk-cli
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds input validation for pull request links in the GetReleasePlanForPullRequest method. The change extracts existing validation logic into a reusable method and updates the response format to use a consistent GenericResponse structure.
Key changes:
- Adds pull request URL validation to
GetReleasePlanForPullRequestmethod - Refactors validation logic into a separate
ValidatePullRequestUrlmethod - Standardizes response format using
GenericResponseobject
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ReleasePlanTool.cs | Adds PR URL validation and refactors response handling to use GenericResponse |
| ReleasePlanToolTests.cs | Adds test cases for valid and invalid PR links, updates existing test to use specs-pr repo |
benbp
approved these changes
Sep 8, 2025
…lanTool.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
praveenkuttappan
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.