Skip to content

Simplify readme generator test services and remove noisy test logging#12021

Merged
benbp merged 1 commit into
Azure:mainfrom
benbp:benbp/test-logging
Sep 9, 2025
Merged

Simplify readme generator test services and remove noisy test logging#12021
benbp merged 1 commit into
Azure:mainfrom
benbp:benbp/test-logging

Conversation

@benbp
Copy link
Copy Markdown
Member

@benbp benbp commented Sep 9, 2025

This updates the readme generator tests to not use the service provider for setup, which was causing a lot of logs to get printed out when tests are passing. Instead we now inject TestLogger manually.

FYI @richardpark-msft

Copilot AI review requested due to automatic review settings September 9, 2025 21:21
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Sep 9, 2025
@benbp benbp self-assigned this Sep 9, 2025
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Sep 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the README generator test services by removing complex mocking infrastructure and reduces noise from test logging. The changes focus on making tests more maintainable and eliminating verbose output during test execution.

  • Replaced complex TestClients record and service provider setup with direct mock injection
  • Changed logging level from LogInformation to LogDebug to reduce noise during agent cleanup operations
  • Renamed MockOutputHelper to TestOutputHelper for better clarity

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
AzureAgentService.cs Changed logging level from Information to Debug for agent cleanup operations
ReadMeGeneratorToolTests.cs Simplified test setup by removing complex service provider configuration and using direct mock injection
MockOutputHelper.cs Renamed class to TestOutputHelper and updated documentation
Comments suppressed due to low confidence (1)

tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Azure/Agent/AzureAgentService.cs:1

  • The model version 'gpt-4.1-mini' does not exist. Valid GPT-4 model names include 'gpt-4', 'gpt-4-turbo', 'gpt-4o', and 'gpt-4o-mini'. Consider using 'gpt-4o-mini' instead.
using Azure.AI.Agents.Persistent;

@benbp benbp force-pushed the benbp/test-logging branch from 47c034c to b2ced5f Compare September 9, 2025 21:23
@benbp benbp force-pushed the benbp/test-logging branch from b2ced5f to 2aa5315 Compare September 9, 2025 21:26
@benbp benbp merged commit 6fc10a5 into Azure:main Sep 9, 2025
13 checks passed
@github-project-automation github-project-automation Bot moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🚀🌒🧑‍🚀 Sep 9, 2025
@benbp benbp deleted the benbp/test-logging branch September 9, 2025 22:19
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚀🌒🧑‍🚀 Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

Development

Successfully merging this pull request may close these issues.

4 participants