Simplify readme generator test services and remove noisy test logging#12021
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the README generator test services by removing complex mocking infrastructure and reduces noise from test logging. The changes focus on making tests more maintainable and eliminating verbose output during test execution.
- Replaced complex
TestClientsrecord and service provider setup with direct mock injection - Changed logging level from
LogInformationtoLogDebugto reduce noise during agent cleanup operations - Renamed
MockOutputHelpertoTestOutputHelperfor better clarity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AzureAgentService.cs | Changed logging level from Information to Debug for agent cleanup operations |
| ReadMeGeneratorToolTests.cs | Simplified test setup by removing complex service provider configuration and using direct mock injection |
| MockOutputHelper.cs | Renamed class to TestOutputHelper and updated documentation |
Comments suppressed due to low confidence (1)
tools/azsdk-cli/Azure.Sdk.Tools.Cli/Services/Azure/Agent/AzureAgentService.cs:1
- The model version 'gpt-4.1-mini' does not exist. Valid GPT-4 model names include 'gpt-4', 'gpt-4-turbo', 'gpt-4o', and 'gpt-4o-mini'. Consider using 'gpt-4o-mini' instead.
using Azure.AI.Agents.Persistent;
47c034c to
b2ced5f
Compare
b2ced5f to
2aa5315
Compare
richardpark-msft
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the readme generator tests to not use the service provider for setup, which was causing a lot of logs to get printed out when tests are passing. Instead we now inject
TestLoggermanually.FYI @richardpark-msft