Create shared helper module for tsp-client commands#12057
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR creates a shared helper module for tsp-client commands to improve code reusability and separation of concerns between CLI commands and business logic.
- Extracts common tsp-client convert logic into
TspClientHelperwith dependency injection - Refactors
TypeSpecConvertToolto use the new helper instead of duplicating convert logic - Updates service registration and test files to accommodate the new dependency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
TspConvertTool.cs |
Removes duplicate convert logic and delegates to the new TspClientHelper |
ServiceRegistrations.cs |
Registers the new ITspClientHelper service for dependency injection |
TspClientHelper.cs |
New helper class implementing the shared tsp-client convert functionality |
ITspClientHelper.cs |
Interface defining the contract for tsp-client operations |
TspConvertToolTest.cs |
Updates test constructor calls to include the new dependency |
praveenkuttappan
approved these changes
Sep 12, 2025
raych1
reviewed
Sep 12, 2025
raych1
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created shared helpers for tsp-client commands (common utility class used by multiple tools) so they provide single implementation of core logic