Add Regenerate feature to Update workflow using shared helper #12066
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds regeneration capability to the TypeSpec client update workflow by integrating with the tsp-client CLI tool. It replaces the placeholder regeneration step with actual code generation functionality.
Key changes:
- Extended the
ITspClientHelperinterface withUpdateGenerationAsyncmethod to invoketsp-client updatecommands - Refactored
TspClientUpdateToolto accept commit SHA instead of spec path and implemented actual regeneration logic - Added logic to update tsp-location.yaml files with new commit SHA and handle output directory resolution
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TspClientUpdateTool.cs | Refactored to use commit SHA, added regeneration logic using ITspClientHelper, and improved directory handling |
| TspClientUpdateResponse.cs | Added Failed enum value to UpdateStage for error handling |
| TspClientHelper.cs | Implemented UpdateGenerationAsync method to execute tsp-client update commands |
| ITspClientHelper.cs | Extended interface with UpdateGenerationAsync method and updated documentation |
| TspClientUpdateToolTests.cs | Updated tests to use mock ITspClientHelper and commit SHA values instead of spec paths |
benbp
reviewed
Sep 12, 2025
benbp
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.