Implement sample verification loop#12298
Conversation
github-actions
Bot
added
the
azsdk-cli
maorleger
force-pushed
the
maorleger/sample-generation-tool
branch
from
386eb70 to
4a2581b
Compare
deyaaeldeen
force-pushed
the
sample-generation-tool
branch
3 times, most recently
from
3ff295f to
d79f309
Compare
maorleger
force-pushed
the
maorleger/sample-generation-tool
branch
3 times, most recently
from
42edaf4 to
dd3a7a2
Compare
|
|
||
| var fixedCode = await microagentService.RunAgentToCompletion(microagent, ct); | ||
|
|
||
| if (string.IsNullOrEmpty(fixedCode)) |
There was a problem hiding this comment.
Should we allow this or throw?
| using Microsoft.Extensions.Logging.Abstractions; | ||
| using Moq; | ||
|
|
||
| namespace Azure.Sdk.Tools.Cli.Tests.Services.Languages |
| using System.Text.Json; | ||
| using System.Text.RegularExpressions; | ||
|
|
||
| // TODO: how do we better organize these? Ideally a language folder with concrete implementations of each cross-language interface |
There was a problem hiding this comment.
Something to consider, we now have Languages under SampleGeneration (which I admittedly added) as well as Languages under Services. Ideally we can provide a single place for organization of language-specific implementations.
It may be something like:
Services/Languages/<language>Service.cs
Which is registered as a service, or maybe if needed:
Services/<scenario>/Languages/<language><scenario>Service // or
Services/Languages/<language>/<language><scenario>Service
etc.
Each concrete implementation can implement multiple interfaces based on a scenario like TypeScriptLanguageService : ISampleVerificationService, ILanguageSpecificChecksService etc
The Q I am asking is how to best organize language-specific implementation of common services / interfaces
deyaaeldeen
force-pushed
the
sample-generation-tool
branch
from
d79f309 to
da4f6d8
Compare
maorleger
force-pushed
the
maorleger/sample-generation-tool
branch
3 times, most recently
from
b0277b1 to
941891b
Compare
deyaaeldeen
force-pushed
the
sample-generation-tool
branch
from
da4f6d8 to
03223e8
Compare
maorleger
force-pushed
the
maorleger/sample-generation-tool
branch
from
941891b to
4965b34
Compare
deyaaeldeen
force-pushed
the
sample-generation-tool
branch
from
03223e8 to
8e2454c
Compare
maorleger
force-pushed
the
maorleger/sample-generation-tool
branch
from
4965b34 to
36f566c
Compare
maorleger
force-pushed
the
maorleger/sample-generation-tool
branch
from
f4cb61c to
d72c699
Compare
deyaaeldeen
force-pushed
the
sample-generation-tool
branch
3 times, most recently
from
0a107ae to
ab60cd9
Compare
deyaaeldeen
force-pushed
the
sample-generation-tool
branch
2 times, most recently
from
d7426c3 to
e8cb366
Compare
|
Hi @maorleger. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
Bot
added
the
no-recent-activity
|
Hi @maorleger. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
ronniegeraghty
added
the
AzSDK Tools Agent
3 participants
This PR implements typechecking and sample verification loop for generated samples. Starting with TypeScript, with the rest to follow.
Typechecking infrastructure
ILanguageTypecheckerinterface to provide a consistent abstraction for language-specific typecheckers, enabling easier extension to additional languages. (Azure.Sdk.Tools.Cli/SampleGeneration/ILanguageTypechecker.cs)LanguageSupportto include aCreateTypecheckerfactory method for instantiating the appropriate typechecker based on language, and addedGetTypecheckingInstructionsto supply language-specific guidance for fixing type errors. (Azure.Sdk.Tools.Cli/SampleGeneration/LanguageSupport.cs)Dependency and namespace organization
LanguageSupport.csto include necessary service and language namespaces for new typechecker and verification logic. (Azure.Sdk.Tools.Cli/SampleGeneration/LanguageSupport.cs)