-
Notifications
You must be signed in to change notification settings - Fork 346
[EngSys] add LatestPreviewDate to -packages.csv files
#8820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3aee9ce to
62deadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the new LatestPreviewDate field to the -packages.csv files to address issue #8819.
- Updated eng/scripts/Update-Release-Versions.ps1 to assign LatestPreviewDate using the first preview version, if available.
- Enhanced eng/scripts/PackageList-Helpers.ps1 to include the LatestPreviewDate property when creating and cloning package objects.
- Modified eng/README.md and various CSV files (ios, cpp, c, android) to document and include the LatestPreviewDate column.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/scripts/Update-Release-Versions.ps1 | Added logic to compute and assign LatestPreviewDate from preview versions. |
| eng/scripts/PackageList-Helpers.ps1 | Updated package creation and cloning functions to support LatestPreviewDate. |
| eng/README.md | Updated documentation to include details on the LatestPreviewDate field. |
| _data/releases/latest/*.csv | Modified CSV files to add the LatestPreviewDate column in the release data. |
| - `LatestGADate` - This field is used to identify the date of when the latest GA package released. | ||
| - `FirstGADate` - This field is used to identify the date of when a new package shipped its first stable release. | ||
| - `FirstPreviewDate` - This field is used to identify the date of when a new package shipped its first preview release. | ||
| - `LatestPreviewDate` - This field is used to identify the date of when the latest preview package released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the LatestPreviewDate interesting? They are supposed to be temporary until the next GA so we shouldn't care about this.
|
@XiaofeiCao closing this PR as I would prefer we not go this route. Talk with me further if you there is more data you think make this work needed. |
LatestPreviewDateto-packages.csvfile #8819