Open
Conversation
Co-authored-by: johanste <15110018+johanste@users.noreply.github.com>
…forwarded kwargs targets Co-authored-by: johanste <15110018+johanste@users.noreply.github.com>
kashifkhan
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sets of guideline changes: (1) remove all Python 2 compatibility guidance and update typing for a 3.9+ minimum, and (2) restrict
**kwargsusage to pass-through scenarios only.Python 2 removal & typing modernization (
design.md,implementation.md)azure-nspkg/azure-<group>-nspkgdependency requirementscollectionsfallback (Python 2.7), "straddling code" PEP 484 reference,(object)base class from examples, "only need to support Python 3" qualifiers, Python 3.4/3.5 historical referenceslist[str]nottyping.List[str]Union/Optionalguidance with comment noting PEP 604X | Ysyntax for when minimum moves to 3.10+Keyword-only arguments over
**kwargs(implementation.md,design.md,documentation.md)python-codestyle-no-kwargs-for-arguments):**kwargsmust not be used for arguments consumed by the method — use keyword-only argspython-codestyle-kwargs-passthrough):**kwargsallowed only for pass-through, must document target API(s)design.mdanddocumentation.mdto require documenting which API(s) receive forwarded**kwargs**kwargsas alternative inpython-codestyle-long-args