Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14420#9722

Closed
azure-sdk wants to merge 8 commits intomainfrom
sync-eng/common-azsdk-benchmark-pipeline-14420
Closed

Sync eng/common directory with azure-sdk-tools for PR 14420#9722
azure-sdk wants to merge 8 commits intomainfrom
sync-eng/common-azsdk-benchmark-pipeline-14420

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14420 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner March 12, 2026 19:45
@azure-sdk azure-sdk requested review from Copilot and jeo02 March 12, 2026 19:45
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Sync adds a new reusable Azure Pipelines job template under eng/common to run azsdk-cli benchmarks via sparse checkout and dotnet run, aligning with changes from azure-sdk-tools PR 14420.

Changes:

  • Added benchmark-job.yml job template with parameters for scenario selection (name/tags/all), model override, and parallelism.
  • Uses sparse-checkout to fetch only the benchmark project + eng/common, then runs benchmarks in a PowerShell step.

DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_MULTILEVEL_LOOKUP: 0
COPILOT_GITHUB_TOKEN: $(azuresdk-copilot-github-pat)
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COPILOT_GITHUB_TOKEN is always populated from $(azuresdk-copilot-github-pat), which makes this job depend on a specific secret variable name being present. To keep this eng/common template reusable and avoid accidental secret coupling, consider taking the token value (or variable name) as a parameter and only setting the env var when provided.

Copilot uses AI. Check for mistakes.
@azure-sdk azure-sdk force-pushed the sync-eng/common-azsdk-benchmark-pipeline-14420 branch from 6102a84 to 7e5df4c Compare March 17, 2026 18:19
@azure-sdk azure-sdk force-pushed the sync-eng/common-azsdk-benchmark-pipeline-14420 branch from 7e5df4c to db87044 Compare March 17, 2026 18:27
@jeo02 jeo02 closed this Mar 17, 2026
@azure-sdk azure-sdk deleted the sync-eng/common-azsdk-benchmark-pipeline-14420 branch March 22, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants