Sync eng/common directory with azure-sdk-tools for PR 14420#9722
Closed
Sync eng/common directory with azure-sdk-tools for PR 14420#9722
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Sync adds a new reusable Azure Pipelines job template under eng/common to run azsdk-cli benchmarks via sparse checkout and dotnet run, aligning with changes from azure-sdk-tools PR 14420.
Changes:
- Added
benchmark-job.ymljob template with parameters for scenario selection (name/tags/all), model override, and parallelism. - Uses sparse-checkout to fetch only the benchmark project +
eng/common, then runs benchmarks in a PowerShell step.
| DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 | ||
| DOTNET_CLI_TELEMETRY_OPTOUT: 1 | ||
| DOTNET_MULTILEVEL_LOOKUP: 0 | ||
| COPILOT_GITHUB_TOKEN: $(azuresdk-copilot-github-pat) |
There was a problem hiding this comment.
COPILOT_GITHUB_TOKEN is always populated from $(azuresdk-copilot-github-pat), which makes this job depend on a specific secret variable name being present. To keep this eng/common template reusable and avoid accidental secret coupling, consider taking the token value (or variable name) as a parameter and only setting the env var when provided.
6102a84 to
7e5df4c
Compare
7e5df4c to
db87044
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14420 See eng/common workflow