Skip to content

Skip delete if the resource (or its parent) has already been removed #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theunrepentantgeek wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Skip delete if the resource (or its parent) has already been removed #5040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fb1725c
Skip delete if the resource (or its parent) has already been removed
theunrepentantgeek Nov 18, 2025
57a33d9
Update tests
theunrepentantgeek Nov 20, 2025
01fb773
Default reconcile policy if unconfigured
theunrepentantgeek Nov 20, 2025
c431605
Move tests to westus3
theunrepentantgeek Nov 21, 2025
7f9d8f0
Redact app configuration keys
theunrepentantgeek Nov 23, 2025
0a7d6f1
Backoff more during replay
theunrepentantgeek Nov 23, 2025
2a97df5
Update recordings
theunrepentantgeek Nov 18, 2025
edab2b0
Update recordings
theunrepentantgeek Nov 23, 2025
bdff1a4
Update test
theunrepentantgeek Nov 23, 2025
f6acd7a
Update recording
theunrepentantgeek Nov 24, 2025
239985f
Rename samples
theunrepentantgeek Nov 24, 2025
c3cfa9d
Update index files
theunrepentantgeek Nov 24, 2025
a474ce0
Add deny-list for extra delete check
theunrepentantgeek Nov 24, 2025
5e313c8
Merge main
theunrepentantgeek Nov 24, 2025
d21f189
Update recording
theunrepentantgeek Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 5 additions & 5 deletions docs/hugo/content/reference/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,9 +1092,9 @@ To install the CRDs for these resources, your ASO configuration must include `we
### Released

These resource(s) are available for use in the current release of ASO. Different versions of a given resource reflect different versions of the Azure ARM API.
| Resource | ARM Version | CRD Version | Supported From | Sample |
|----------------------------------------------------------------------------------------|-------------|---------------|----------------|------------------------------------------------------------------------------------------------------------------------------|
| [ServerFarm]({{< relref "/reference/web/v1api20220301#ServerFarm" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api/v1api20220301_serverfarm.yaml) |
| [Site]({{< relref "/reference/web/v1api20220301#Site" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api/v1api20220301_site.yaml) |
| [SitesSourcecontrol]({{< relref "/reference/web/v1api20220301#SitesSourcecontrol" >}}) | 2022-03-01 | v1api20220301 | v2.12.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api/v1api20220301_sitessourcecontrol.yaml) |
| Resource | ARM Version | CRD Version | Supported From | Sample |
|----------------------------------------------------------------------------------------|-------------|---------------|----------------|--------------------------------------------------------------------------------------------------------------------------------------|
| [ServerFarm]({{< relref "/reference/web/v1api20220301#ServerFarm" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api20220301/v1api20220301_serverfarm.yaml) |
| [Site]({{< relref "/reference/web/v1api20220301#Site" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api20220301/v1api20220301_site.yaml) |
| [SitesSourcecontrol]({{< relref "/reference/web/v1api20220301#SitesSourcecontrol" >}}) | 2022-03-01 | v1api20220301 | v2.12.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api20220301/v1api20220301_sitessourcecontrol.yaml) |

10 changes: 5 additions & 5 deletions docs/hugo/content/reference/web/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ To install the CRDs for these resources, your ASO configuration must include `we
### Released

These resource(s) are available for use in the current release of ASO. Different versions of a given resource reflect different versions of the Azure ARM API.
| Resource | ARM Version | CRD Version | Supported From | Sample |
|----------------------------------------------------------------------------------------|-------------|---------------|----------------|------------------------------------------------------------------------------------------------------------------------------|
| [ServerFarm]({{< relref "/reference/web/v1api20220301#ServerFarm" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api/v1api20220301_serverfarm.yaml) |
| [Site]({{< relref "/reference/web/v1api20220301#Site" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api/v1api20220301_site.yaml) |
| [SitesSourcecontrol]({{< relref "/reference/web/v1api20220301#SitesSourcecontrol" >}}) | 2022-03-01 | v1api20220301 | v2.12.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api/v1api20220301_sitessourcecontrol.yaml) |
| Resource | ARM Version | CRD Version | Supported From | Sample |
|----------------------------------------------------------------------------------------|-------------|---------------|----------------|--------------------------------------------------------------------------------------------------------------------------------------|
| [ServerFarm]({{< relref "/reference/web/v1api20220301#ServerFarm" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api20220301/v1api20220301_serverfarm.yaml) |
| [Site]({{< relref "/reference/web/v1api20220301#Site" >}}) | 2022-03-01 | v1api20220301 | v2.0.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api20220301/v1api20220301_site.yaml) |
| [SitesSourcecontrol]({{< relref "/reference/web/v1api20220301#SitesSourcecontrol" >}}) | 2022-03-01 | v1api20220301 | v2.12.0 | [View](https://github.com/Azure/azure-service-operator/tree/main/v2/samples/web/v1api20220301/v1api20220301_sitessourcecontrol.yaml) |

5 changes: 3 additions & 2 deletions .../crd_appconfiguration_configstore_test.go → ...ration_configstore_v20220501_crud_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ import (
"github.com/Azure/azure-service-operator/v2/pkg/genruntime"
)

// If recording this test, might need to manually purge the old App config: az appconfig purge --name asotest-confstore-fsrajl
// If recording this test, might need to manually purge the old App config: az appconfig purge --name <name>
// Through the portal, search for "App Conifguration" and then "Manage deleted stores"

func Test_AppConfiguration_ConfigurationStore_CRUD(t *testing.T) {
func Test_AppConfiguration_ConfigurationStore_20220501_CRUD(t *testing.T) {
t.Parallel()

if *isLive {
Expand Down
2 changes: 1 addition & 1 deletion v2/internal/controllers/containerservice_managedcluster_crud_v1api20231001_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func AKS_ManagedCluster_TrustedAccessRoleBinding_20231001_CRUD(
sa := newStorageAccount(tc, resourceGroup)
tc.CreateResourceAndWait(sa)

kv := newVault20210401preview("kv", tc, resourceGroup)
kv := newVault20210401preview("kv2", tc, resourceGroup)
tc.CreateResourceAndWait(kv)

// Create workspace
Expand Down
Loading