chore: Update the azure-rest-api-specs submodule#5474
chore: Update the azure-rest-api-specs submodule#5474theunrepentantgeek wants to merge 71 commits into
Conversation
github-project-automation
Bot
moved this to In Progress
in Azure Service Operator Roadmap
theunrepentantgeek
force-pushed
the
feature/update-submodule
branch
from
000a401 to
20ccb96
Compare
theunrepentantgeek
changed the title
matthchr
left a comment
matthchr
left a comment
There was a problem hiding this comment.
Few questions, overall looks great to me
| │ ├── Owner: *genruntime.KnownResourceReference | ||
| │ ├── Pool: *Object (1 property) | ||
| │ ├── Pool: *Object (2 properties) | ||
| │ │ ├── AdditionalProperties: map[string]v1.JSON |
There was a problem hiding this comment.
Would like to understand where this came from and if it's intended/supposed to be here.
There was a problem hiding this comment.
(Same applies to the previous API version)
There was a problem hiding this comment.
In commit 6389cc78 we improved our handling for arrays of unknown values, opting to treat them as arrays of any - this flows through into AdditionalProperties showing up in a few new places.
(We needed this because the typespec migrations would otherwise have resulted in a few of our CRDs losing properties they'd already had.)
There was a problem hiding this comment.
| │ │ └── "Enabled" | ||
| │ ├── RedisConfiguration: *Object (17 properties) | ||
| │ ├── RedisConfiguration: *Object (18 properties) | ||
| │ │ ├── AdditionalProperties: map[string]v1.JSON |
| │ ├── TargetResourceId: *string | ||
| │ ├── Type: *string | ||
| │ └── Weight: *int | ||
| ├── Endpoints: Object (1 property)[] |
There was a problem hiding this comment.
Did we determine the cause here?
There was a problem hiding this comment.
It was to do with the $resourceEmbeddedInParent config - did I miss fixing one up? I'll check this.
| @@ -13,7 +13,8 @@ Workspace: Resource | |||
| │ │ └── Rule 2: Pattern: "^[A-Za-z0-9][A-Za-z0-9-]+[A-Za-z0-9]$" | |||
| │ ├── DefaultDataCollectionRuleResourceReference: *genruntime.ResourceReference | |||
| │ ├── Etag: *string | |||
| │ ├── Features: *Object (5 properties) | |||
| │ ├── Features: *Object (6 properties) | |||
| │ │ ├── AdditionalProperties: map[string]v1.JSON | |||
There was a problem hiding this comment.
Similar pattern again -- I need to look into what caused it.
| SourceVault: | ||
| Id: | ||
| $referenceType: arm | ||
| KeyForDiskEncryptionSet: | ||
| KeyUrl: | ||
| $importConfigMapMode: optional | ||
| EncryptionSetProperties: |
There was a problem hiding this comment.
Curious: why move?
Alpha order? But if so KeyForDisk... is in the wrong spot too, no?
There was a problem hiding this comment.
Alphabetical ordering, yes - but I didn't want to create too much chaos by moving all the things, so I just made it closer.
| @@ -2,7 +2,8 @@ typeTransformers: | |||
| - name: DeploymentProperties | |||
| property: CurrentCapacity | |||
| remove: true | |||
| because: This property should have been marked readonly but wasn't. | |||
| because: This property is read-only and cannot be set by the user. | |||
There was a problem hiding this comment.
Weird changing only this comment?
| @@ -166,6 +167,8 @@ groupModelConfiguration: | |||
| # TODO[breaking]: This is actually a real resource that can be created as a child of a loadbalancer, | |||
| # but we didn't model it that way initially, so marking it as not a resource for now to maintain backcompat | |||
| $resourceEmbeddedInParent: LoadBalancer | |||
| # BackendAddressPool_STATUS_LoadBalancer_SubResourceEmbedded: | |||
There was a problem hiding this comment.
Commented out? Intentional? Delete?
| WorkspaceFeatures: | ||
| ClusterResourceId: | ||
| $referenceType: arm | ||
| $referenceType: arm |
| @@ -102,7 +103,11 @@ func (scanner *SchemaScanner) AddTypeHandler(schemaType SchemaType, handler Type | |||
| } | |||
|
|
|||
| // RunHandler triggers the appropriate handler for the specified schemaType | |||
| func (scanner *SchemaScanner) RunHandler(ctx context.Context, schemaType SchemaType, schema Schema) (astmodel.Type, error) { | |||
| func (scanner *SchemaScanner) RunHandler( | |||
There was a problem hiding this comment.
These updates are nice but I am curious why they were needed?
There was a problem hiding this comment.
Not strictly needed, I made them as I was messing around trying to solve the v1.JSON problem, and then decided to keep them when I committed that fix.
What this PR does
Updates the submodule used to drive our code generator.
This is the first update since January 2026 and there's been a LOT of movement as product teams migrate to typespec internally.
Special notes
We should probably plan to do this monthly in the medium term, so that we don't get further large changes like this one.
How does this PR make you feel?
Checklist