Restore missing dryrun values that were removed in 10.27 #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
gapra-msft
reviewed
Jan 27, 2025
| Source string | ||
| Destination string | ||
| }{ | ||
| derefString := func(str *string) string { |
There was a problem hiding this comment.
Can we use common.IffNotNil here instead of this?
gapra-msft
reviewed
Jan 27, 2025
|
|
||
| var aTier blob.AccessTier | ||
| var srcSize int64 | ||
| if d.SourceSize != nil { |
There was a problem hiding this comment.
same for this, I think we can just use common.IffNotNil here and for AccessTier
gapra-msft
approved these changes
Jan 27, 2025
dphulkar-msft
approved these changes
Feb 12, 2025
wonwuakpa-msft
approved these changes
Feb 19, 2025
|
@adreed-msft , can you sync this branch with main. After that we can proceed with merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: In 10.27.0, the dryrun output was reworked to output more "useful" information to interop with the testing framework. In the process, unintentionally, several values were removed from most outputs which some customers relied upon. This PR restores the missing values, providing feature parity with 10.27.0
Related Links:
Issue
Type of Change
How Has This Been Tested?
A test has been added to validate the output of all new fields.