Migrate release pipeline to 1espt #2933
Conversation
gapra-msft
requested review from
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
|
@adreed-msft and @dphulkar-msft could I get some reviews on this? |
|
LGTM. |
I added a recent pipeline run. I didnt want to run all steps due to them actually affecting publicly accessible things. I ran the other steps last month when this pipeline was code complete and verified they successfully worked. |
common/version.go
Outdated
| @@ -1,6 +1,6 @@ | |||
| package common | |||
|
|
|||
| const AzcopyVersion = "10.28.0" | |||
| const AzcopyVersion = "10.28.1" | |||
There was a problem hiding this comment.
was this just for testing or is this an intentional version bump?
There was a problem hiding this comment.
Version bump was for testing as a final sanity check. We have since removed all the effectively duplicate releases
| displayName: 'Checkout repository' | ||
|
|
||
| # Custom script to install Go-lang | ||
| - task: ShellScript@2 |
There was a problem hiding this comment.
Works for amd but it's not working on arm, so I just do it this way for both for the sake of keeping it unduplicated.
|
|
||
| - script: | | ||
| go vet | ||
| displayName: 'Golang Vet - Linux' |
There was a problem hiding this comment.
Assuming we aren't breaking rules and committing straight to master, is there a need to run go vet here?
There was a problem hiding this comment.
I was thinking the same thing when working on this - I am aligned in removing this. I think it makes more sense to be in the CI pipeline. Thoughts?
| host_architecture: 'arm64' | ||
| host_suffix: 'arm64' | ||
|
|
||
| - job: Windows |
There was a problem hiding this comment.
Linux is templated, we should prob do the same with win/macOS just to componentize things.
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Release pipeline migration to 1espt
Related Links:
Type of Change
How Has This Been Tested?
Running pipeline manually with AzCopy 10.28.1
https://dev.azure.com/azstorage/AzCopy-NextGen/_build/results?buildId=25904&view=results
Thank you for your contribution to AzCopy!