Replaced md5 token info hash with sha256 #2947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
seanmcc-msft
assigned seanmcc-msft, adreed-msft and dphulkar-msft and unassigned seanmcc-msft
|
@wonwuakpa-msft Can we add a E2ETest or UT covering this scenario? |
adreed-msft
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the md5 token information hash checksum with a safer SHA256 hashing algorithm
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
[Team thread]
[Documents]
[Email Subject]
Type of Change
How Has This Been Tested?
Included a new test file
credCacheInternal_windows_test.goThank you for your contribution to AzCopy!