[WIP] Fix incorrect count of pending transfers when a job is resumed #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonwuakpa-msft
requested review from
gapra-msft,
adreed-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
| @@ -137,11 +137,13 @@ func (cca *resumeJobController) ReportProgressOrExit(lcm common.LifecycleMgr) (t | |||
| // indicate whether constrained by disk or not | |||
| perfString, diskString := getPerfDisplayText(summary.PerfStrings, summary.PerfConstraint, duration, false) | |||
|
|
|||
| var xfersDoneFailSkip = summary.TransfersCompleted + summary.TransfersFailed + summary.TransfersSkipped | |||
| pending := common.Iff(summary.TotalTransfers > xfersDoneFailSkip, summary.TotalTransfers-xfersDoneFailSkip, 0) | |||
There was a problem hiding this comment.
We will have to figure out why are we getting this negative value instead of just setting this value to 0.
wonwuakpa-msft
changed the title
adreed-msft
requested changes
Mar 17, 2025
| @@ -137,11 +137,13 @@ func (cca *resumeJobController) ReportProgressOrExit(lcm common.LifecycleMgr) (t | |||
| // indicate whether constrained by disk or not | |||
| perfString, diskString := getPerfDisplayText(summary.PerfStrings, summary.PerfConstraint, duration, false) | |||
|
|
|||
| var xfersDoneFailSkip = summary.TransfersCompleted + summary.TransfersFailed + summary.TransfersSkipped | |||
| pending := common.Iff(summary.TotalTransfers > xfersDoneFailSkip, summary.TotalTransfers-xfersDoneFailSkip, 0) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
The count of pending transfers after a job is resumed was incorrect. If the pending value is negative, it defaults to 0
Related Links:
Issues
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!