Default to using the customized retry policy #2962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
5 tasks
| if errorCode != "" { | ||
| if _, ok = storageErrorCodes[errorCode]; ok { | ||
| if resp != nil { | ||
| if storageErrorCodes, ok := RetryStatusCodes[resp.StatusCode]; ok { |
There was a problem hiding this comment.
Should we put explicit logs here saying we are retrying due to custom policy etc.
gapra-msft
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: The extra platform-specific check for the wsarecv error does not occur if no special retry policy is specified.
Related Links:
Resolves an issue I noticed with Retry
wsarecv: An existing connection was forcibly closed by the remote host.#2916 while writing scenario generators for memory testingType of Change